Open
Conversation
The switch from ssrLoadModule to ModuleRunner removed stack trace source mapping. Re-add setErrorInterceptor call so errors in route handlers get source-mapped before the error overlay renders them, and ssrFixStacktrace in the outer catch for module loading errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lishaduck
commented
Mar 29, 2026
| ) as FetchHandler; | ||
| mod.setErrorInterceptor?.((err: unknown) => { | ||
| if (err instanceof Error) { | ||
| server.ssrFixStacktrace(err); |
Contributor
Author
There was a problem hiding this comment.
If this works to fix it, then that's great, but in theory it shouldn't be needed 🤔
server.ssrFixStacktraceandserver.ssrRewriteStacktracedo not have to be called when using the Module Runner APIs. The stack traces will be updated unlesssourcemapInterceptoris set tofalse. — SSR Using ModuleRunner API
I assumed it was because sourcemapInterceptor was indeed false because Deno had nooped process.setSourceMapsEnabled, but fixing that didn't seem to fix it.
Relevant Vite code: https://github.com/vitejs/vite/blob/99897d27b44dd73307fa03e2f11f0baa1a1dc939/packages/vite/src/node/ssr/runtime/serverModuleRunner.ts#L58-L72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from/stacked upon #3634.