fix(dim_freshness): check WAL mtime to avoid false-stale freshness reports#22
Open
jsherlockppb wants to merge 2 commits into
Open
fix(dim_freshness): check WAL mtime to avoid false-stale freshness reports#22jsherlockppb wants to merge 2 commits into
jsherlockppb wants to merge 2 commits into
Conversation
…ports SQLite in WAL mode writes to session-store.db-wal first; the main .db file is only updated on checkpoint. The previous check used only the main file's mtime, so the freshness dimension would report AMBER/RED even when sessions were actively being recorded into the WAL. Fix: take the most recent mtime across both files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SQLite in WAL mode writes new data to
session-store.db-walfirst. The main.dbfile is only updated when a checkpoint occurs (periodically, not on every write).The
dim_freshnesscheck was usingos.path.getmtime(DB_PATH)— the main file only. This meant that even with active sessions being recorded, the freshness dimension would report AMBER or RED because the main file's mtime hadn't changed.Fix
Take the most recent mtime across both the main DB and the WAL file:
This correctly reflects when data was last written, regardless of checkpoint timing.
Tests added
New file:
src/session_recall/tests/test_dim_freshness.py(5 tests)test_green_when_db_recently_modifiedtest_red_when_db_missingtest_wal_mtime_used_when_newer_than_dbtest_db_mtime_used_when_no_waltest_stale_when_both_db_and_wal_are_oldVerified locally
0.0h old(GREEN) after active sessions, vs previously showing 68h old (AMBER)