test: add canister upgrade test for key manager and encrypted maps#214
Draft
test: add canister upgrade test for key manager and encrypted maps#214
Conversation
altkdf
commented
Aug 4, 2025
| @@ -1,13 +1,19 @@ | |||
| import IcVetkeys "mo:ic-vetkeys"; | |||
| import Types "mo:ic-vetkeys/Types"; | |||
| import IcVetkeys "../../../ic_vetkeys/src"; | |||
Contributor
Author
There was a problem hiding this comment.
We have to rely on the local version for a short time because we extracted the data types from the classes to enable enhanced orthogonal persistence. This will be set back right after we bump the package.
Contributor
Author
There was a problem hiding this comment.
Maybe it's actually a better idea to extract those changes to a separate PR, update the package, and first then merge this PR.
Contributor
There was a problem hiding this comment.
@altkdf, sure, @randombit and me can take care of that.
Contributor
Author
|
8f15560 should be reverted here after Motoko |
altkdf
commented
Aug 5, 2025
| output | ||
| } | ||
|
|
||
| pub fn upgrade_for_enhanced_orthogonal_persistence( |
Contributor
Author
There was a problem hiding this comment.
This is a workaround until Pocket IC has dfinity/ic#6141 upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.