Add Checkout to destroy_review_app Example#122
Merged
josegonzalez merged 2 commits intodokku:masterfrom Mar 10, 2026
Merged
Conversation
Member
|
Probably don't need a fetch-depth here as code isn't getting pushed. |
Removed fetch-depth option from checkout step.
Contributor
Author
|
I removed the fetch-depth and added a comment that the checkout may not be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example is missing the
checkoutstep. The destruction will still work, but thebin/ci-post-review-app-destroyscript will not run (because it doesn't exist.)See my initial confused issue over here: dokku/ci-docker-image#162