feat(footnotes): Support lists and images in footnotes#3325
Open
james-atticus wants to merge 2 commits intodolanmiu:masterfrom
Open
feat(footnotes): Support lists and images in footnotes#3325james-atticus wants to merge 2 commits intodolanmiu:masterfrom
james-atticus wants to merge 2 commits intodolanmiu:masterfrom
Conversation
james-atticus
commented
Jan 20, 2026
|
|
||
| public prepForXml(context: IContext): IXmlableObject | undefined { | ||
| if (context.viewWrapper instanceof DocumentWrapper) { | ||
| if (!(context.viewWrapper instanceof FontWrapper)) { |
Author
There was a problem hiding this comment.
There was already logic in next-compiler.ts to call this.numberingReplacer.replace for headers and footers, but the replacements weren't being put into Numbering because of this viewWrapper check. I had a look at what implements IViewWrapper and it looks like the only one we now want to exclude here is FontWrapper.
Author
|
@dolanmiu any chance you can take a look at this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2876
Adds support for images and lists in footnotes:
Drive-by fix for lists in headers/footers: