Skip to content

OS Windows support#5

Open
mukexa wants to merge 1 commit intodolmen-go:masterfrom
mukexa:master
Open

OS Windows support#5
mukexa wants to merge 1 commit intodolmen-go:masterfrom
mukexa:master

Conversation

@mukexa
Copy link
Copy Markdown

@mukexa mukexa commented Jan 20, 2020

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 20, 2020

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.39%. Comparing base (c1f1850) to head (0ef389d).
⚠️ Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
resolvepath.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   52.59%   52.39%   -0.21%     
==========================================
  Files           6        6              
  Lines         521      523       +2     
==========================================
  Hits          274      274              
- Misses        181      182       +1     
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolmen
Copy link
Copy Markdown
Member

dolmen commented Mar 11, 2021

Could you describe the problem with the input files and the error reported?

Anyway, patching the resolvePath function with reference to runtime.GOOS doesn't feel right. OS-related issues in filepath handling should happen more around calls to the loadFile function.

@dolmen dolmen added the help wanted Extra attention is needed label Mar 11, 2021
@mukexa
Copy link
Copy Markdown
Author

mukexa commented Mar 22, 2021

(google translate)
Sorry for not describing the problem right away.
I don't work with Golang right now.
If I remember correctly...
The problem is the following, Windows does not use a slash at the beginning of the path.
c:/user
not
/c:/user

@dolmen
Copy link
Copy Markdown
Member

dolmen commented Jun 2, 2022

@mukexa Thanks for the feedback. That's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants