Fixed the .bump method#231
Closed
samichaignonmejai wants to merge 1 commit intodomokane:masterfrom
Closed
Conversation
Owner
|
Hi - Sami. Thanks for finding this. I reviewed the code but fixed it differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dominic,
While working on the Advanced Derivatives coursework with M. Kerkhof, I noticed that the
.bumpmethod indiscount_curve.pywas not behaving as expected.This PR proposes a fix to ensure that the method correctly bumps the curve values, allowing users to adjust the curve reliably.
Changes made:
.bumpExample usage after fix can be found in the
FINDISCOUNTCURVE_Introduction.ipynbnotebook.I would be happy to receive feedback or suggestions on this implementation.
Thank you,
Sami