Skip to content

Follow up on unresolved feedback from #51272#51756

Open
ReubenBond wants to merge 6 commits intodotnet:mainfrom
ReubenBond:pr-51272-feedback-20260216
Open

Follow up on unresolved feedback from #51272#51756
ReubenBond wants to merge 6 commits intodotnet:mainfrom
ReubenBond:pr-51272-feedback-20260216

Conversation

@ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Feb 16, 2026

Summary

  • Apply valid unresolved review feedback from Add zone pivots for Orleans 10 documentation #51272 across Orleans docs.
  • Refine version-specific zone pivot content for dashboard and grain directory docs.
  • Apply style updates for heading links, callout usage, and list punctuation.
  • Remove unused zone pivot metadata and simplify nested tab headings.

Not applied

  • Feedback about TOC entries for deployment/docker-deployment.md and host/powershell-client.md was skipped because those files don't exist on current main.
  • The tutorial-1 prerequisite pivot suggestion was optional and not required for correctness.

Internal previews

📄 File 🔗 Preview link
docs/orleans/dashboard/index.md Orleans Dashboard
docs/orleans/deployment/deploy-to-azure-container-apps.md Deploy Orleans to Azure Container Apps
docs/orleans/deployment/handling-failures.md Failure handling
docs/orleans/deployment/kubernetes.md Kubernetes hosting
docs/orleans/deployment/troubleshooting-azure-cloud-services-deployments.md Troubleshoot Azure Cloud Service deployments
docs/orleans/deployment/troubleshooting-deployments.md docs/orleans/deployment/troubleshooting-deployments
docs/orleans/grains/event-sourcing/journaledgrain-basics.md JournaledGrain basics
docs/orleans/host/configuration-guide/typical-configurations.md Typical configurations
docs/orleans/host/silo-lifecycle.md Orleans silo lifecycles
docs/orleans/tutorials-and-samples/tutorial-1.md Tutorial: Create a minimal Orleans application

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 16, 2026 21:57
@dotnetrepoman dotnetrepoman bot added this to the February 2026 milestone Feb 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies remaining review feedback from #51272 across Orleans documentation by refining version-based zone pivots, simplifying headings, and aligning Markdown styling (callouts, headings, and list punctuation).

Changes:

  • Refines Orleans version pivots (notably in grain directory and dashboard docs) to show version-appropriate content.
  • Updates Markdown style (callouts, headings, and list punctuation) across multiple Orleans deployment and hosting articles.
  • Removes unused/undesired metadata and simplifies some nested tab/heading patterns.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/orleans/host/silo-lifecycle.md Removes unused zone_pivot_groups metadata from a non-pivoted page.
docs/orleans/host/grain-directory.md Adjusts version pivot scoping for default directory text, strongly-consistent directory content, and ADO.NET directory section.
docs/orleans/host/configuration-guide/typical-configurations.md Simplifies headings by removing tab-link syntax in favor of plain headings.
docs/orleans/grains/event-sourcing/journaledgrain-basics.md Converts inline “Important” text to a standard IMPORTANT callout.
docs/orleans/deployment/troubleshooting-deployments.md Simplifies exception heading text (but drops xref in the 7.0+ pivot section).
docs/orleans/deployment/troubleshooting-azure-cloud-services-deployments.md Simplifies exception heading text (but drops xref).
docs/orleans/deployment/kubernetes.md Adds end punctuation to list items for style consistency.
docs/orleans/deployment/handling-failures.md Minor wording update (“cannot”→“can’t”).
docs/orleans/deployment/deploy-to-azure-container-apps.md Tweaks tab heading label and adds list-item punctuation.
docs/orleans/dashboard/index.md Refines version-specific guidance for dashboard availability across pivots.
Comments suppressed due to low confidence (1)

docs/orleans/host/grain-directory.md:59

  • The "Strongly-consistent in-cluster directory" section is now scoped to pivot="orleans-10-0", but the earlier Orleans 9.0/10.0 table still lists Strongly-Consistent In-Cluster as available for Orleans 9.0. Update the table pivot/content to match the section’s actual availability (or expand the section pivot if Orleans 9.0 supports it).
:::zone target="docs" pivot="orleans-10-0"

## Strongly-consistent in-cluster directory

[!INCLUDE [orleans-10-preview](../includes/orleans-10-preview.md)]

ReubenBond and others added 5 commits February 16, 2026 14:03
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant