Follow up on unresolved feedback from #51272#51756
Open
ReubenBond wants to merge 6 commits intodotnet:mainfrom
Open
Follow up on unresolved feedback from #51272#51756ReubenBond wants to merge 6 commits intodotnet:mainfrom
ReubenBond wants to merge 6 commits intodotnet:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Applies remaining review feedback from #51272 across Orleans documentation by refining version-based zone pivots, simplifying headings, and aligning Markdown styling (callouts, headings, and list punctuation).
Changes:
- Refines Orleans version pivots (notably in grain directory and dashboard docs) to show version-appropriate content.
- Updates Markdown style (callouts, headings, and list punctuation) across multiple Orleans deployment and hosting articles.
- Removes unused/undesired metadata and simplifies some nested tab/heading patterns.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/orleans/host/silo-lifecycle.md | Removes unused zone_pivot_groups metadata from a non-pivoted page. |
| docs/orleans/host/grain-directory.md | Adjusts version pivot scoping for default directory text, strongly-consistent directory content, and ADO.NET directory section. |
| docs/orleans/host/configuration-guide/typical-configurations.md | Simplifies headings by removing tab-link syntax in favor of plain headings. |
| docs/orleans/grains/event-sourcing/journaledgrain-basics.md | Converts inline “Important” text to a standard IMPORTANT callout. |
| docs/orleans/deployment/troubleshooting-deployments.md | Simplifies exception heading text (but drops xref in the 7.0+ pivot section). |
| docs/orleans/deployment/troubleshooting-azure-cloud-services-deployments.md | Simplifies exception heading text (but drops xref). |
| docs/orleans/deployment/kubernetes.md | Adds end punctuation to list items for style consistency. |
| docs/orleans/deployment/handling-failures.md | Minor wording update (“cannot”→“can’t”). |
| docs/orleans/deployment/deploy-to-azure-container-apps.md | Tweaks tab heading label and adds list-item punctuation. |
| docs/orleans/dashboard/index.md | Refines version-specific guidance for dashboard availability across pivots. |
Comments suppressed due to low confidence (1)
docs/orleans/host/grain-directory.md:59
- The "Strongly-consistent in-cluster directory" section is now scoped to
pivot="orleans-10-0", but the earlier Orleans 9.0/10.0 table still lists Strongly-Consistent In-Cluster as available for Orleans 9.0. Update the table pivot/content to match the section’s actual availability (or expand the section pivot if Orleans 9.0 supports it).
:::zone target="docs" pivot="orleans-10-0"
## Strongly-consistent in-cluster directory
[!INCLUDE [orleans-10-preview](../includes/orleans-10-preview.md)]
docs/orleans/deployment/troubleshooting-azure-cloud-services-deployments.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not applied
Internal previews