Skip to content

Remove orphaned test data files and migrate FSharp.Data to NuGet#19254

Merged
T-Gro merged 5 commits intomainfrom
copilot/remove-unused-test-data-files
Feb 18, 2026
Merged

Remove orphaned test data files and migrate FSharp.Data to NuGet#19254
T-Gro merged 5 commits intomainfrom
copilot/remove-unused-test-data-files

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

Removes orphaned test data files and migrates FSharp.Data dependency from checked-in DLLs to NuGet package.

Deleted Files

  • tests/service/data/sqlite-net-spike/ (entire folder)

    • Orphaned spike project never integrated into test suite
    • No references in solution files, project files, or tests
    • Project GUID {BE87D723-5EAB-4B69-8F65-5EC072EF9E46} appears nowhere else
    • Uses deprecated tooling (packages.config, .NET Framework 4.5, FSharp.Compiler.Tools 4.1.27)
  • tests/service/data/FSharp.Data.DesignTime.dll

    • No references found in codebase
    • Replaced by NuGet package
  • tests/service/data/FSharp.Data.dll

    • Replaced by NuGet package

FSharp.Data Migration to NuGet

  • Added FSharp.Data version 6.6.0 as a PackageReference to FSharp.Compiler.Service.Tests.fsproj
  • Created tests/FSharp.Compiler.Service.Tests/NuGet.Config to enable nuget.org as a package source
  • Updated ProjectAnalysisTests.fs to reference FSharp.Data.dll from the test assembly output directory using PathRelativeToTestAssembly instead of hardcoded paths to checked-in files
  • Project25 tests now use FSharp.Data from NuGet package, providing both runtime and design-time components

Verification

Code search confirmed zero references:

  • sqlite-net-spike - only self-references within deleted folder
  • FSharp.Data.DesignTime - no matches
  • Project GUID - only in deleted .fsproj

All tests pass (2,074 passed, 0 failed, 29 skipped).

Original prompt

Summary

Remove unused/orphaned test data files from tests/service/data/ that are not referenced anywhere in the codebase.

Files to Delete

1. tests/service/data/sqlite-net-spike/ (entire folder)

This is a dead spike/prototype project that was never integrated into the test suite:

  • Not referenced in any solution file (.sln)
  • Not referenced in any project file (.fsproj, .csproj)
  • Not referenced in any test file
  • Not referenced in any CI/build configuration
  • Project GUID {BE87D723-5EAB-4B69-8F65-5EC072EF9E46} appears nowhere else in the repository
  • Uses legacy/obsolete tooling:
    • packages.config (deprecated)
    • Paket references
    • Targets .NET Framework 4.5
    • References FSharp.Compiler.Tools.4.1.27 (very old)

Files in this folder:

  • sqlite-net-spike.fsproj
  • Program.fs
  • packages.config
  • paket.references

2. tests/service/data/FSharp.Data.DesignTime.dll

This DLL file is completely orphaned:

  • No references found anywhere in the codebase
  • Searching for "FSharp.Data.DesignTime" returns zero results outside the file itself
  • Note: FSharp.Data.dll (without "DesignTime") IS used by ProjectAnalysisTests.fs and should NOT be deleted

Verification

Code search was performed for:

  • sqlite-net-spike - only found within the folder itself
  • sqlitenetspike - only found within the folder itself
  • BE87D723-5EAB-4B69-8F65-5EC072EF9E46 (project GUID) - only found in the .fsproj file itself
  • FSharp.Data.DesignTime - no results

Impact

  • No tests will be affected
  • No builds will be affected
  • Reduces repository size and maintenance burden

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove orphaned test data files from repository Remove orphaned test data files from tests/service/data/ Feb 4, 2026
Copilot AI requested a review from T-Gro February 4, 2026 14:08
T-Gro

This comment was marked as outdated.

@github-actions
Copy link
Contributor

✅ No release notes required

1 similar comment
@github-actions
Copy link
Contributor

✅ No release notes required

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Copilot AI changed the title Remove orphaned test data files from tests/service/data/ Remove orphaned test data files and migrate FSharp.Data to NuGet Feb 11, 2026
@dotnet dotnet deleted a comment from Copilot AI Feb 13, 2026
@T-Gro T-Gro force-pushed the copilot/remove-unused-test-data-files branch 3 times, most recently from 8e16576 to 839d76d Compare February 13, 2026 14:51
… provider

- Revert FSharp.Compiler.Service.Tests.fsproj (remove FSharp.Data PackageReference)
- Remove NuGet.Config
- Resolve FSharp.Data via #r nuget script resolution at test time
- Copy runtime + design-time DLLs to staging dir so type provider can find
  its design-time component with --simpleresolution
- Change Project25 tests to FactSkipOnSignedBuild (skip when NuGet unavailable)
- Make Project25.options lazy
- Update namespace attribute expectation for NuGet-resolved FSharp.Data
@T-Gro T-Gro force-pushed the copilot/remove-unused-test-data-files branch from 839d76d to 10919fd Compare February 13, 2026 15:00
@T-Gro T-Gro marked this pull request as ready for review February 13, 2026 18:27
@T-Gro T-Gro requested a review from a team as a code owner February 13, 2026 18:27
@T-Gro T-Gro requested a review from abonie February 13, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

Comments