[Wasm RyuJit] fix issue in RewriteLocalStackStore#124673
Open
AndyAyersMS wants to merge 3 commits intodotnet:mainfrom
Open
[Wasm RyuJit] fix issue in RewriteLocalStackStore#124673AndyAyersMS wants to merge 3 commits intodotnet:mainfrom
AndyAyersMS wants to merge 3 commits intodotnet:mainfrom
Conversation
Need to capture the original type before bashing to TYP_I_IMPL.
github-actions
bot
added
the
area-CodeGen-coreclr
Member
Author
|
@dotnet/jit-contrib PTAL |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the WasmRyuJit register allocator's RewriteLocalStackStore function. The function was incorrectly using the type from lclNode after it had been changed to TYP_I_IMPL, instead of preserving the original type. The fix captures the original type in a storeType variable before the type is modified.
Changes:
- Captures the original node type before it is changed to
TYP_I_IMPL - Uses the captured type when creating the store node, ensuring the correct type information is preserved
SingleAccretion
approved these changes
Feb 20, 2026
adamperlin
approved these changes
Feb 21, 2026
adamperlin
reviewed
Feb 21, 2026
adamperlin
requested changes
Feb 21, 2026
Contributor
adamperlin
left a comment
adamperlin
left a comment
There was a problem hiding this comment.
One question about the TypeIs check immediately after ChangeType
kg
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to capture the original type before bashing to TYP_I_IMPL.