Fix StylusPlugIn OnStylusDown/Move/Up invoked on UI thread and called out of order#11108
Open
lindexi wants to merge 1 commit intodotnet:mainfrom
Open
Fix StylusPlugIn OnStylusDown/Move/Up invoked on UI thread and called out of order#11108lindexi wants to merge 1 commit intodotnet:mainfrom
lindexi wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where StylusPlugIn methods (OnStylusDown/Move/Up) were being called out of order due to potential null reference issues with stylusDevice.CriticalActiveSource. The fix ensures thread safety by using inputReport.InputSource as the primary source, falling back to stylusDevice.CriticalActiveSource only when needed.
- Replace direct usage of
stylusDevice.CriticalActiveSourcewith null-coalescing pattern usinginputReport.InputSource
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11103
Main PR
Description
See #11103
The
stylusDevice.CriticalActiveSourcemay be null. And thestylusDevice.CriticalActiveSourcewill update frominputReport.InputSource. So that we directly useinputReport.InputSourcewill be safe and reasonable.This PR can not 100% fix the #11103 , but this PR can alleviate the problem.
Customer Impact
Fix the out of roder issues.
Regression
None.
Testing
Test pass in my touch device.
And I build and publish my version to NuGet: https://www.nuget.org/packages/dotnetCampus.WPF.Resource/6.0.4-alpha07-test10
Risk
Normal. As description says, the
stylusDevice.CriticalActiveSourcewill update frominputReport.InputSourcein UI thread. We can directly useinputReport.InputSourcein Stylus Input thread safely.Microsoft Reviewers: Open in CodeFlow