Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
WalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@composer.json`:
- Line 43: In composer.json replace the unstable branch constraint for the
dependency "drupal/drupal-extension" (currently "dev-main") with a stable
semantic version (e.g. "^5.1.0" or "^4.2.0") to match the project's
"minimum-stability": "stable" and "prefer-stable": true; after updating the
constraint run composer update drupal/drupal-extension to regenerate
composer.lock so builds are deterministic and reproducible.
composer.json
Outdated
| "drevops/phpcs-standard": "^0.6.2", | ||
| "drupal/coder": "^9@alpha", | ||
| "drupal/drupal-extension": "^5.1", | ||
| "drupal/drupal-extension": "dev-main", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification: check how drupal/drupal-extension is constrained and locked.
set -euo pipefail
echo "composer.json constraint:"
rg -n '"drupal/drupal-extension"\s*:\s*".*"' composer.json
if [ -f composer.lock ]; then
echo
echo "composer.lock entry (packages-dev/packages):"
python3 - <<'PY'
import json
with open("composer.lock", "r", encoding="utf-8") as f:
data = json.load(f)
pkgs = (data.get("packages-dev") or []) + (data.get("packages") or [])
matches = [p for p in pkgs if p.get("name") == "drupal/drupal-extension"]
if not matches:
print("No drupal/drupal-extension entry found in composer.lock")
for p in matches:
print("locked_version=", p.get("version"))
print("source_ref=", (p.get("source") or {}).get("reference"))
print("dist_ref=", (p.get("dist") or {}).get("reference"))
PY
else
echo "composer.lock not found; cannot verify lock pinning."
fiRepository: drevops/vortex
Length of output: 186
🏁 Script executed:
#!/bin/bash
# Check how composer.lock is handled and stable versions
if [ -f .gitignore ]; then
echo "=== .gitignore entries related to composer ==="
rg -i "composer\.lock|vendor" .gitignore || echo "No composer.lock/.gitignore entries found"
fi
echo
echo "=== Checking composer.json for minimum-stability ==="
rg -A2 '"minimum-stability"' composer.jsonRepository: drevops/vortex
Length of output: 261
🌐 Web query:
drupal/drupal-extension available versions stable releases
💡 Result:
Stable (non-dev, non-alpha/beta/rc) releases of drupal/drupal-extension currently available on Packagist, by branch (latest in each): [1]
- 5.x:
v5.1.0(latest),v5.0.0 - 4.x:
v4.2.1(latest),v4.1.0,v4.0.1,v4.0.0 - 3.4.x:
v3.4.1(latest),v3.4.0 - 3.3.x:
v3.3.1(latest),v3.3.0 - 3.2.x:
v3.2.3(latest),v3.2.2,v3.2.1,v3.2.0 - 3.1.x:
v3.1.5(latest),v3.1.4,v3.1.3,v3.1.2,v3.1.1,v3.1.0 - 3.0.x:
v3.0.13(latest) down tov3.0.0 - 1.0.x:
v1.0.9(latest) down tov1.0.0 - 0.1.x:
v0.1.6(latest) down tov0.1.0
If you tell me which Drupal core major (e.g., 9/10/11) and PHP you’re targeting, I can suggest the best branch to use.
Source: Packagist package page for drupal/drupal-extension. [1]
Use a stable version of drupal/drupal-extension instead of dev-main.
The project declares "minimum-stability": "stable" and "prefer-stable": true, yet this dependency uses a floating development branch. This contradicts the stability policy and creates non-deterministic builds (especially since composer.lock is not tracked). Stable versions are available on Packagist (e.g., v5.1.0, v4.2.1, v3.4.1). Update the constraint to a semantic version such as ^5.1.0 or ^4.2.0 to respect the project's stability preference and ensure reproducible builds.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@composer.json` at line 43, In composer.json replace the unstable branch
constraint for the dependency "drupal/drupal-extension" (currently "dev-main")
with a stable semantic version (e.g. "^5.1.0" or "^4.2.0") to match the
project's "minimum-stability": "stable" and "prefer-stable": true; after
updating the constraint run composer update drupal/drupal-extension to
regenerate composer.lock so builds are deterministic and reproducible.
AlexSkrypnyk
force-pushed
the
feature/try-drupalextension
branch
from
01b60da to
dd6258f
Compare
This comment has been minimized.
This comment has been minimized.
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
===========================================
- Coverage 78.87% 66.93% -11.95%
===========================================
Files 124 41 -83
Lines 6482 2386 -4096
Branches 44 0 -44
===========================================
- Hits 5113 1597 -3516
+ Misses 1369 789 -580 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
1 participant
Closes #
Summary by CodeRabbit