Correction of USB device detection logic#1
Open
smandon wants to merge 2 commits intodrivin:pr-892-drivinfrom
Open
Correction of USB device detection logic#1smandon wants to merge 2 commits intodrivin:pr-892-drivinfrom
smandon wants to merge 2 commits intodrivin:pr-892-drivinfrom
Conversation
The new 4.6" model has 320x960 resolution and uses the same USB protocol as the 8.8" v1.1 and 9.2 models.
Author
|
I also made a commit that adds support for the new 4.6" model. It uses the same protocol as the 8.8 v1.1 and 9.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When you added the support for the 9.2" model, you introduced a flaw in the USB device detection logic.
In find_usb_device() you loop over product ids in the PRODUCT_ID list but never stop when a device is found, which means it will only be able to detect devices matching the last product id in the list (i.e the 9.2" model) and raise ValueError for other models (the 8.8" model currently).
I just added a break once a device is found, so that the 8.8" model is properly detected (and other models that might be added later).