Skip to content

Single tab burn: Dialog changes#8089

Merged
0nko merged 8 commits intodevelopfrom
feature/ondrej/single-tab-burn-update-single-burn
Mar 26, 2026
Merged

Single tab burn: Dialog changes#8089
0nko merged 8 commits intodevelopfrom
feature/ondrej/single-tab-burn-update-single-burn

Conversation

@0nko
Copy link
Copy Markdown
Member

@0nko 0nko commented Mar 25, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1213760433348129?focus=true

Description

This PR contains the following changes:

  • After "Delete This Tab" is tapped, the app respects the "Launch on start" settings and opens a specific website, if set (NTP otherwise)
  • On Duck.ai Tab: Only one “Delete This Chat", which is primary
  • On Normal Tab: Top button is “Delete This Tab” and is primary, bottom button is “Delete All” and is secondary (regardless of the number of tabs)

Steps to test this PR

Prerequisite: Enable singleTabFireDialog feature flag

Normal tab with multiple tabs open

  • Open 2+ tabs, load some websites and tap the fire button from the browser
  • Verify "Delete This Tab" is the top button (primary/red)
  • Verify "Delete All" is the bottom button (secondary/outlined)
  • Tap "Delete This Tab" — verify the tab is replaced correctly

Normal tab - single tab open

  • Open only 1 tab, tap the fire button from the browser
  • Verify both buttons are shown: "Delete This Tab" (primary, top) and "Delete All" (secondary, bottom)
  • Tap "Delete This Tab" — verify the tab is replaced with NTP

Duck.ai tab

  • Navigate to Duck.ai, start a chat, then tap the fire button from the browser
  • Verify title reads "Delete this chat?"
  • Verify only one button is shown: "Delete Chat" (primary/red)
  • Verify "Delete All" button is NOT shown
  • Verify no subtitle about Duck.ai chat history is shown
  • Tap "Delete Chat" — verify the chat is deleted and a new Duck.ai tab opens

Launch on start setting respected after single tab burn

  • Go to Settings > General > Show on App Launch, set to a specific page (e.g. example.com)
  • Open a normal tab, tap fire, tap "Delete This Tab"
  • Verify the replacement tab navigates to the configured specific page

Fire dialog from Settings

  • Open fire dialog from Settings > Data Clearing > Delete Tabs and Data
  • Verify only "Delete All" is shown as a primary (red) button
  • Verify "Delete This Tab" is NOT shown

Fire dialog from Tab Switcher

  • Open the tab switcher, tap the fire button
  • Verify only "Delete All" is shown as a primary (red) button
  • Verify "Delete This Tab" is NOT shown

Data deletion subtitle

  • Clear app storage data
  • Navigate to Duck.ai
  • Tap on the Fire button
  • Verify no subtitle is shown regardless of the current open tabs count
  • Open a normal tab and tap on a Fire button
  • Verify "Deleting site data can sign you out of accounts." subtitle appears
  • Navigate to Duck.ai
  • Start a long download, open fire dialog on a normal tab — verify "This will cancel downloads in progress." subtitle appears
  • While download is still in progress, open fire dialog on a Duck.ai tab — verify no downloads subtitle is shown

Note

Medium Risk
Medium risk because it changes data-clearing post-action navigation/restart behavior and refactors the fire dialog state/pixel flow, which could affect clearing outcomes and telemetry.

Overview
Updates the single-tab fire dialog UX: button hierarchy/visibility now depends on origin and whether the selected tab is Duck.ai (e.g., Duck.ai shows a single primary Delete Chat action and suppresses site/download subtitles; normal browser tabs show Delete This Tab as primary with Delete All as secondary).

After clearing a single tab, the replacement tab URL now respects the user’s Show on App Launch setting (using the configured specific page when set, while still prioritizing a fresh Duck.ai chat URL for Duck.ai tabs). Telemetry is adjusted by removing the clear_all_button_only pixels and adding a from_focused_ntp boolean parameter to the browser daily fire-button pixel, with corresponding test updates.

Written by Cursor Bugbot for commit 78643bd. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown
Member Author

0nko commented Mar 25, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko requested review from CDRussell and removed request for CDRussell March 25, 2026 18:30
@0nko 0nko force-pushed the feature/ondrej/single-tab-burn-update-single-burn branch from eb065df to fc46084 Compare March 26, 2026 09:43
@0nko 0nko requested a review from CDRussell March 26, 2026 09:44
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@CDRussell
Copy link
Copy Markdown
Member

CDRussell commented Mar 26, 2026

@0nko, the specs say "Delete All Tabs", e.g.

  • "Verify "Delete All Tabs" is the bottom button (secondary/outlined)
  • bottom button is “Delete All Tabs” and is secondary
  • etc...

But I see Delete All
Screenshot_20260326_095703

@CDRussell
Copy link
Copy Markdown
Member

CDRussell commented Mar 26, 2026

For #8089 (comment)

  • clarified that the PR testing instructions needed to be updated and that "Delete All" is what we want

There's an outstanding lint error which is being fixed already.

LGTM.

@0nko 0nko merged commit 948af2e into develop Mar 26, 2026
14 checks passed
@0nko 0nko deleted the feature/ondrej/single-tab-burn-update-single-burn branch March 26, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants