Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
app/src/main/java/com/duckduckgo/app/global/view/SingleTabFireDialogViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/global/view/SingleTabFireDialogViewModel.kt
Outdated
Show resolved
Hide resolved
eb065df to
fc46084
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Member
|
@0nko, the specs say "Delete All Tabs", e.g.
|
CDRussell
approved these changes
Mar 26, 2026
Member
|
For #8089 (comment)
There's an outstanding lint error which is being fixed already. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1213760433348129?focus=true
Description
This PR contains the following changes:
Steps to test this PR
Prerequisite: Enable
singleTabFireDialogfeature flagNormal tab with multiple tabs open
Normal tab - single tab open
Duck.ai tab
Launch on start setting respected after single tab burn
Fire dialog from Settings
Fire dialog from Tab Switcher
Data deletion subtitle
Note
Medium Risk
Medium risk because it changes data-clearing post-action navigation/restart behavior and refactors the fire dialog state/pixel flow, which could affect clearing outcomes and telemetry.
Overview
Updates the single-tab fire dialog UX: button hierarchy/visibility now depends on origin and whether the selected tab is Duck.ai (e.g., Duck.ai shows a single primary Delete Chat action and suppresses site/download subtitles; normal browser tabs show Delete This Tab as primary with Delete All as secondary).
After clearing a single tab, the replacement tab URL now respects the user’s Show on App Launch setting (using the configured specific page when set, while still prioritizing a fresh Duck.ai chat URL for Duck.ai tabs). Telemetry is adjusted by removing the
clear_all_button_onlypixels and adding afrom_focused_ntpboolean parameter to the browser daily fire-button pixel, with corresponding test updates.Written by Cursor Bugbot for commit 78643bd. This will update automatically on new commits. Configure here.