Angular Material: OneOf Enum Control Renderer#2551
Open
daniel-shuy wants to merge 2 commits intoeclipsesource:masterfrom
Open
Angular Material: OneOf Enum Control Renderer#2551daniel-shuy wants to merge 2 commits intoeclipsesource:masterfrom
daniel-shuy wants to merge 2 commits intoeclipsesource:masterfrom
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed
AutocompleteControlRenderertoEnumControlRendererto be consistent with other renderer setsThe
OneOfEnumControlRendererhas the same implementation as theEnumControlRenderer, the only difference being that it takes inEnumOption[]instead ofstring[], so that a different label can be displayed instead of the value:jsonforms/packages/core/src/mappers/renderer.ts
Lines 320 to 323 in 3a9bc74
oneOf.constis mapped toEnumOption.valueoneOf.titleis mapped toEnumOption.label