Add inline modifier to avoid build problems#183
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses linker/build issues caused by non-inline function definitions living in header files within the mars2grib “deductions” backend, by marking those header-defined functions as inline.
Changes:
- Mark wave frequency grid helper functions as
inlineinwaveFrequencyGrid.h. - Mark wave direction grid helper functions as
inlineinwaveDirectionGrid.h. - Mark additional header-defined utilities as
inline(pvArray.h,detail/timeUtils.h,bitsPerValue.h) to prevent multiple-definition link errors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/metkit/mars2grib/backend/deductions/waveFrequencyGrid.h | Adds inline to header-defined wave frequency grid helpers to avoid ODR/linker issues. |
| src/metkit/mars2grib/backend/deductions/waveDirectionGrid.h | Adds inline to header-defined wave direction grid helpers to avoid ODR/linker issues. |
| src/metkit/mars2grib/backend/deductions/pvArray.h | Adds inline to a header-defined PV lookup helper to avoid multiple definitions across TUs. |
| src/metkit/mars2grib/backend/deductions/detail/timeUtils.h | Adds inline to header-defined date/time conversion helpers to avoid multiple definitions. |
| src/metkit/mars2grib/backend/deductions/bitsPerValue.h | Adds inline to a header-defined bits-per-value default mapping helper to avoid multiple definitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dsarmany
force-pushed
the
bugfix/add-inline-to-deductions
branch
from
3a1cdf4 to
87efe4a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #183 +/- ##
========================================
Coverage 62.61% 62.61%
========================================
Files 303 303
Lines 11554 11554
Branches 1029 1028 -1
========================================
Hits 7234 7234
Misses 4320 4320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: