Feature - add analytics

[edge-marge]

do not merge - missing distinct_id

[orcist]

@edge-marge wouldn't this implementation create a new instance of AnalyticsApi every time you access the property? Maybe it would be better to declare it once as a property and reuse it after?

private AnalyticsApi Analytics = new AnalyticsApi(getDistinctId());

also, it seems this implementation has hardcoded the UTM source, could you instead get the value dynamically from EdgegapWindowMetadata.DEFAULT_UTM_SOURCE_TAG?

[orcist]

in addition to the comments above, could you also modify the events for Rebuild from Source feature so that the different stages are not stored in a new property rebuild_step but instead you concatenate that into the button name?

e.g. 5. Upload to Edgegap > Rebuild from Source > Containerize

this will make it much much easier to build analysis compared to storing two different properties.

[orcist]

when would this ever be null? I thought we collapse and disable all the sections if you don't have a valid API token...

[orcist]

would be useful to add the validation error to the error message for clarity like this. needs to be tested though before merging.

Suggested change

	AnalyticsApi analyticsApi = getAnalyticsApi();
	if (!string.IsNullOrEmpty(await ValidateDockerRequirement(false)))
	{
	if (_organizationInfo is not null)
	{
	Dictionary<string, string> properties = new Dictionary<string, string>()
	{
	{ "identifier", _organizationInfo.Identifier },
	{ "provider", _organizationInfo.Provider },
	{ "button_name", buttonName },
	{ "utm_source", EdgegapWindowMetadata.DEFAULT_UTM_SOURCE_TAG },
	{ "succeeded", false.ToString() },
	{ "error_message", "Docker validation failed" },
	string error = await ValidateDockerRequirement(false);
	if (!string.IsNullOrEmpty(error))
	{
	if (_organizationInfo is not null)
	{
	Dictionary<string, string> properties = new Dictionary<string, string>()
	{
	{ "identifier", _organizationInfo.Identifier },
	{ "provider", _organizationInfo.Provider },
	{ "button_name", buttonName },
	{ "utm_source", EdgegapWindowMetadata.DEFAULT_UTM_SOURCE_TAG },
	{ "succeeded", false.ToString() },
	{ "error_message", $"Docker validation failed. {error}" },

[orcist]

seems like a duplicate, you're setting the identifier in the block above.

[orcist]

seems like duplicate identifier

[orcist]

duplicate identifier also