dRICH aerogel trapezoidal tiling by Luisa by locchiuto · Pull Request #1032 · eic/epic

locchiuto · 2026-01-29T16:13:37Z

Briefly, what does this PR introduce?

The aerogel, previously implemented as a single block, has been divided into two perfectly overlapping parts. A carbon-fiber structure has been integrated within the configuration, designed to mechanically support and encapsulate each aerogel element.
The main structural parameters are now easily configurable through the drich.xml file located in epic/compact/pid, without requiring direct modifications to the source code.

What kind of change does this PR introduce?

Bug fix (issue #__)
New feature (issue #__)
Tiled aerogel optics, tunable size
Documentation update
Other: __

Please check if this PR fulfills the following:

Tests for the changes have been added
Documentation has been added / updated
Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

veprbl · 2026-02-03T18:57:00Z

@locchiuto Are you able to address the review comments? Let me know if something is unclear.

@chchatte92 Did you have a chance to look at this?

chchatte92 · 2026-02-03T20:42:53Z

@chchatte92 Did you have a chance to look at this?
Hi @veprbl, I was busy with the other dRICH today, TFile issue.
I will give a detailed look tomorrow, but I agree to all of your comments and will see if further commemts I have had.

chchatte92 · 2026-02-04T15:26:34Z

@locchiuto are these comments clear to you and can you react to the comments?

for more information, see https://pre-commit.ci

chchatte92 · 2026-02-18T16:50:26Z

@locchiuto did you push your changes to your branch?

chchatte92 · 2026-02-18T16:54:37Z

@locchiuto did you push your changes to your branch?

Please ignore. I can see the changes.

chchatte92 · 2026-03-11T15:08:26Z

Hi @veprbl sorry for the late reply. I am now totally lost with this PR. I still see the changes that I was mentioning. I am not sure, where @locchiuto is pushing her changes. I guess I will implement the changes this weekend. Just to mention: still in the source code the variables are accessed. @veprbl I see that you have removed the this varible `d'.

chchatte92

@veprbl I see now your implemented changes.

veprbl · 2026-03-11T15:19:44Z

Yes, please check that this is correct. Overwrite my work if you need to.

chchatte92 · 2026-03-15T12:16:49Z

@veprbl and @locchiuto I am working with this PR and my realization is that you are placing the aerogel holder structure and not the aerogel itself. That is in this PR we DON'T have an aerogel. @locchiuto, Can you please kindly point me to the fork that you made where I guess you had the aerogel placement?
I thought, I would just work on the PR comments, which I see have not been implemented. However, I see a bigger issue.

Chandra

chchatte92 · 2026-03-15T12:18:02Z

@veprbl I have converted this PR into a draft as I would like to make sure we are putting right thing in the main branch.

chchatte92 · 2026-03-15T12:28:07Z

+        double phiStart = p * segmentSpacing;
+        double phiEnd   = phiStart + segmentAngularWidth;
+
+        ConeSegment segmentSolid(crownHeight / 2.0, rMin_Zminus, rMax_Zminus, rMin_Zplus,


@locchiuto in this version of the code, where are you subtracting the aerogel radiator by using the coronas?

for more information, see https://pre-commit.ci

chchatte92 · 2026-03-15T14:40:37Z

@veprbl I have made some recent changes. When you have some time, can you please give a super-critical look?

for more information, see https://pre-commit.ci

chchatte92 · 2026-04-02T15:29:25Z

@veprbl I have ensured

structure is Aerogel daughter
There is only one structure
The filter and airgap has structure radius.

Can you please review now?
Thanks a lot!

veprbl · 2026-04-02T18:36:50Z

+    segmentSolidUnion_half = std::accumulate(
+        segmentSolids.begin() + 1, segmentSolids.end(), segmentSolids[0],
+        [](const Solid& a, const Solid& b) { return UnionSolid(a, b, Position(0., 0., 0.)); });
+    crownAndSegmentSolid_half = UnionSolid(crownSolidUnion_half, segmentSolidUnion_half);


This is a union of two shapes constructed as union chains of cones or cone segments. Boolean operations are ineffective in Geant. Since cone shapes are concentric and non-intersecting, could you modify the algorithm to place all of those inside the aerogelVol directly?

Implemented, but that appears to reveal another extrusion.

The inner crown ring to sits exactly outside the aerogel bounds:

> DRICH_geo INFO === AEROGEL VOLUME DIMENSIONS === > DRICH_geo INFO Aerogel half-height: 2.000000 > DRICH_geo INFO Aerogel rmin1 (front): 12.955806 > DRICH_geo INFO Aerogel rmax1 (front): 88.800000 > DRICH_geo INFO Aerogel rmin2 (back): 13.259580 > DRICH_geo INFO Aerogel rmax2 (back): 88.800000 > DRICH_geo INFO === CROWN 0 DIMENSIONS === > DRICH_geo INFO Crown half-height: 2.000000 > DRICH_geo INFO Crown rmin1 (bottom): 12.948211 > DRICH_geo INFO Crown rmax1 (bottom): 12.955806 > DRICH_geo INFO Crown rmin2 (top): 15.844059 > DRICH_geo INFO Crown rmax2 (top): 15.851654

Also dimension on the other side don't align by a lot (13 vs 16 cm?).

Hi Dmitry, I am taking a couple of days off. I am back on Tuesday and will work on it. Thanks.

Extrusion happens in bottom left corner, I believe.

Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat>

for more information, see https://pre-commit.ci

dRICH aerogel trapezoidal tiling by Luisa

bd9b030

github-actions Bot added topic: forward Positive-rapidity detectors (hadron-going side) topic: PID Particle identification labels Jan 29, 2026

veprbl reviewed Jan 29, 2026

View reviewed changes

chchatte92 reviewed Feb 4, 2026

View reviewed changes

Comment thread src/DRICH_geo.cpp Outdated

Comment thread src/DRICH_geo.cpp Outdated

Comment thread src/DRICH_geo.cpp Outdated

Tiled aerogel new version after PR comments

8c546d4

locchiuto force-pushed the dRICH_tiled_aerogel_Luisa branch from d2ccef3 to 8c546d4 Compare February 16, 2026 15:31

[pre-commit.ci] auto fixes from pre-commit.com hooks

0ae146c

for more information, see https://pre-commit.ci

chchatte92 reviewed Feb 16, 2026

View reviewed changes

Comment thread compact/pid/drich.xml Outdated

chchatte92 and others added 2 commits February 16, 2026 16:50

Merge branch 'main' into dRICH_tiled_aerogel_Luisa

d13235d

Merge branch 'main' into dRICH_tiled_aerogel_Luisa

124303c

veprbl added 5 commits February 26, 2026 10:46

DRICH_geo.cpp: simplify comments

833d1a2

Merge branch 'main' into dRICH_tiled_aerogel_Luisa

0a8cdee

Merge branch 'main' into dRICH_tiled_aerogel_Luisa

b016ae2

drich.xml: remove unused DRICH_d_square

61d58e6

remove duplicate code

5c36716

veprbl requested a review from chchatte92 March 9, 2026 23:58

Merge branch 'main' into dRICH_tiled_aerogel_Luisa

3032d5f

chchatte92 reviewed Mar 11, 2026

View reviewed changes

chchatte92 self-requested a review March 11, 2026 15:12

chchatte92 marked this pull request as draft March 15, 2026 12:17

chchatte92 assigned chchatte92 and locchiuto Mar 15, 2026

chchatte92 reviewed Mar 15, 2026

View reviewed changes

chchatte92 and others added 2 commits March 15, 2026 15:38

Adding modifications: PR comments, added Aerogel volume

e57e89e

[pre-commit.ci] auto fixes from pre-commit.com hooks

9f31df9

for more information, see https://pre-commit.ci

chchatte92 and others added 4 commits March 19, 2026 12:39

Subtraction removed; structure added as daughter

450e507

[pre-commit.ci] auto fixes from pre-commit.com hooks

092cc0c

for more information, see https://pre-commit.ci

Structure sent back as Aerogel Daughter

b468d4c

[pre-commit.ci] auto fixes from pre-commit.com hooks

c973ea1

for more information, see https://pre-commit.ci

veprbl reviewed Apr 2, 2026

View reviewed changes

veprbl and others added 2 commits April 2, 2026 15:25

refactor: replace UnionSolid with direct volume placement in crown

5b446e4

Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat>

[pre-commit.ci] auto fixes from pre-commit.com hooks

6984074

for more information, see https://pre-commit.ci

Conversation

locchiuto commented Jan 29, 2026

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

veprbl commented Feb 3, 2026

Uh oh!

chchatte92 commented Feb 3, 2026

Uh oh!

chchatte92 commented Feb 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chchatte92 commented Feb 18, 2026

Uh oh!

chchatte92 commented Feb 18, 2026

Uh oh!

chchatte92 commented Mar 11, 2026

Uh oh!

chchatte92 left a comment

Choose a reason for hiding this comment

Uh oh!

veprbl commented Mar 11, 2026

Uh oh!

chchatte92 commented Mar 15, 2026

Uh oh!

chchatte92 commented Mar 15, 2026

Uh oh!

chchatte92 Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

chchatte92 commented Mar 15, 2026

Uh oh!

chchatte92 commented Apr 2, 2026

Uh oh!

veprbl Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

veprbl Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

chchatte92 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

veprbl Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants