feat(plugin): add setup to rspack plugin#3451
Open
noghartt wants to merge 2 commits intoelectron:mainfrom
Open
feat(plugin): add setup to rspack plugin#3451noghartt wants to merge 2 commits intoelectron:mainfrom
noghartt wants to merge 2 commits intoelectron:mainfrom
Conversation
Member
|
Hi @noghartt. CI failed, can you fix it? |
Author
ofc, i'll need to write more tests for these cases and fix the ci it seems that the types aren't well matched yet |
Member
|
It looks like a log of this code is duplicated, I wonder if there is a way we can write this plugin so it uses the webpack plugin impl but swaps out the underlying webpack calls for rspack to avoid massive duplication |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
The idea of this PR is to bring a new plugin allowing us to use the rspack as a possible bundler for Electron with forge tooling. By the fact that
rspackhas a similar API related for Webpack, it follows the same approach. As the example below: