Skip to content

fix: Electron dependency path for PnP#3622

Closed
rtritto wants to merge 2 commits intoelectron:mainfrom
rtritto:fix-get-electron-dep
Closed

fix: Electron dependency path for PnP#3622
rtritto wants to merge 2 commits intoelectron:mainfrom
rtritto:fix-get-electron-dep

Conversation

@rtritto
Copy link

@rtritto rtritto commented Jun 8, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Related #3209

Fix #3611

@rtritto rtritto force-pushed the fix-get-electron-dep branch 2 times, most recently from e92088f to 39313b2 Compare June 8, 2024 13:19
@rtritto
Copy link
Author

rtritto commented Jun 9, 2024

I need some help, after I run yarn electron-forge start, I get:

image

@rtritto rtritto mentioned this pull request Jun 9, 2024
4 tasks
@rtritto rtritto force-pushed the fix-get-electron-dep branch from 39313b2 to ce93017 Compare June 10, 2024 00:05
@rtritto rtritto changed the title fix: get Electron dependency path fix: Electron dependency path for PnP Jun 12, 2024
@rtritto rtritto force-pushed the fix-get-electron-dep branch 2 times, most recently from 5006406 to 7e345d9 Compare June 19, 2024 11:07
@rtritto rtritto force-pushed the fix-get-electron-dep branch from 7e345d9 to af99e16 Compare June 19, 2024 11:13
@rtritto
Copy link
Author

rtritto commented Jun 20, 2024

Closed in favor of #3209

@rtritto rtritto closed this Jun 20, 2024
@rtritto rtritto deleted the fix-get-electron-dep branch June 20, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PnP] Cannot find the package "electron"

1 participant