Skip to content

meson suggestion#26

Merged
danirabbit merged 5 commits intodanirabbit/mesonfrom
ryonakano/meson-suggestion
May 4, 2026
Merged

meson suggestion#26
danirabbit merged 5 commits intodanirabbit/mesonfrom
ryonakano/meson-suggestion

Conversation

@ryonakano
Copy link
Copy Markdown
Member

Suggestion for #24

Changes Summary

Suggestions

Other Related Changes

  • Correct install dir
    • Use the install destination path currently as defined in Debian packaging
  • Indentation fix
    • meson: Unify to 4 space indentation
    • README: Remove unnecessary indentation

Checklist

  • Building .deb files by debuild -us -uc and they contains the same files/directories as before

After:

user@elementary-daily:~/work/elementary/fonts (ryonakano/meson-suggestion %)$ dpkg-deb -c ../fonts-roboto-mono-elementary_5.1.0_all.deb
drwxr-xr-x root/root         0 2018-10-16 15:31 ./
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/doc/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/doc/fonts-roboto-mono-elementary/
-rw-r--r-- root/root       278 2018-10-16 15:31 ./usr/share/doc/fonts-roboto-mono-elementary/changelog.gz
-rw-r--r-- root/root       974 2018-10-16 15:31 ./usr/share/doc/fonts-roboto-mono-elementary/copyright
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/fonts/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/fonts/truetype/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/
-rw-r--r-- root/root    113684 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Bold.ttf
-rw-r--r-- root/root    121700 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-BoldItalic.ttf
-rw-r--r-- root/root    119716 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Italic.ttf
-rw-r--r-- root/root    117852 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Light.ttf
-rw-r--r-- root/root    126484 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-LightItalic.ttf
-rw-r--r-- root/root    113524 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Medium.ttf
-rw-r--r-- root/root    122560 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-MediumItalic.ttf
-rw-r--r-- root/root    113500 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Regular.ttf
-rw-r--r-- root/root    117020 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Thin.ttf
-rw-r--r-- root/root    120364 2018-10-16 15:31 ./usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-ThinItalic.ttf
user@elementary-daily:~/work/elementary/fonts (ryonakano/meson-suggestion %)$ dpkg-deb -c ../fonts-redacted-elementary_5.1.0_all.deb
drwxr-xr-x root/root         0 2018-10-16 15:31 ./
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/doc/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/doc/fonts-redacted-elementary/
-rw-r--r-- root/root       278 2018-10-16 15:31 ./usr/share/doc/fonts-redacted-elementary/changelog.gz
-rw-r--r-- root/root       974 2018-10-16 15:31 ./usr/share/doc/fonts-redacted-elementary/copyright
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/fonts/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/fonts/truetype/
drwxr-xr-x root/root         0 2018-10-16 15:31 ./usr/share/fonts/truetype/redacted-elementary/
-rw-r--r-- root/root     19468 2018-10-16 15:31 ./usr/share/fonts/truetype/redacted-elementary/redacted-script-bold.ttf
-rw-r--r-- root/root     19516 2018-10-16 15:31 ./usr/share/fonts/truetype/redacted-elementary/redacted-script-light.ttf
-rw-r--r-- root/root     19368 2018-10-16 15:31 ./usr/share/fonts/truetype/redacted-elementary/redacted-script-regular.ttf
user@elementary-daily:~/work/elementary/fonts (ryonakano/meson-suggestion %)$

Before:

user@elementary-daily:~/work/elementary/fonts (ryonakano/meson-suggestion %)$ dpkg -L fonts-roboto-mono-elementary
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/fonts-roboto-mono-elementary
/usr/share/doc/fonts-roboto-mono-elementary/changelog.Debian.gz
/usr/share/doc/fonts-roboto-mono-elementary/copyright
/usr/share/fonts
/usr/share/fonts/truetype
/usr/share/fonts/truetype/roboto-mono-elementary
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Bold.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-BoldItalic.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Italic.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Light.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-LightItalic.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Medium.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-MediumItalic.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Regular.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-Thin.ttf
/usr/share/fonts/truetype/roboto-mono-elementary/RobotoMono-ThinItalic.ttf
user@elementary-daily:~/work/elementary/fonts (ryonakano/meson-suggestion %)$ dpkg -L fonts-redacted-elementary
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/fonts-redacted-elementary
/usr/share/doc/fonts-redacted-elementary/changelog.Debian.gz
/usr/share/doc/fonts-redacted-elementary/copyright
/usr/share/fonts
/usr/share/fonts/truetype
/usr/share/fonts/truetype/redacted-elementary
/usr/share/fonts/truetype/redacted-elementary/redacted-script-bold.ttf
/usr/share/fonts/truetype/redacted-elementary/redacted-script-light.ttf
/usr/share/fonts/truetype/redacted-elementary/redacted-script-regular.ttf
user@elementary-daily:~/work/elementary/fonts (ryonakano/meson-suggestion %)$

@ryonakano ryonakano requested a review from danirabbit May 4, 2026 00:06
Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better, thank you!

@danirabbit danirabbit merged commit a92456c into danirabbit/meson May 4, 2026
3 checks passed
@danirabbit danirabbit deleted the ryonakano/meson-suggestion branch May 4, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants