feat(expert): make log level for log files configurable#561
Draft
katafrakt wants to merge 1 commit intoelixir-lang:mainfrom
Draft
feat(expert): make log level for log files configurable#561katafrakt wants to merge 1 commit intoelixir-lang:mainfrom
katafrakt wants to merge 1 commit intoelixir-lang:mainfrom
Conversation
This adds a command-line flag --log-level which affects the filtering of the log level in expert.log and project.log. It keeps :debug as default.
Contributor
Author
|
Currently this approach has too many problems to be ready for review. It affects editor log level too, among others. |
|
When reporting the verbose logging issue I've tried my hand at setting the log level and compiling the app. I found logging quite complicated, how come you don't use the standard |
Collaborator
|
@emdvtc we did until we unified elixir and LSP logs |
Contributor
Author
|
I like #563 more, I think this should be closed, because setting CLI flag is not very user-friendly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a command-line flag --log-level which affects the filtering of the log level in expert.log and project.log. It keeps
:debugas default.Addresses #541 (I don't want to close it automatically, as we may want to continue there for feedback)
First few logs on info level are kept always for debugging. This is when I set the log level to
error: