You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@LudwigBoess a few things that i think should be fixed:
There is really no reason not to just have:
structNoCustomPrtlUpdate_t {};
I really don't see why we need a template with an empty operator(). especially given that in the example pgen, the template is directly on the operator() instead.
this is not very safe (in pgens/examples/custom_particle_update):
should use coord_t<D>. also, again, there is no reason the template is not on the class itself.
in the same pgens/examples/custom_particle_update, the coordinate conversions are incorrect (i think). i + di is not the same as the x coordinate, as they are in different coordinate systems. and likewise, (i + di) / beta will not be equal to time.
why do we give access to xp at all? isn't it redundant? xp_Ph would make more sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.