fix: replace invalid plugin install hints with marketplace form#35
Merged
ericchansen merged 1 commit intomainfrom May 7, 2026
Merged
fix: replace invalid plugin install hints with marketplace form#35ericchansen merged 1 commit intomainfrom
ericchansen merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates user-facing plugin reinstall hints to use the marketplace install spec (name@marketplace) instead of an invalid . spec, and stabilizes a few upgrade-related tests by preventing git-related environment leakage.
Changes:
- Update PluginsTab detail/upgrade messaging to recommend
copilot plugin install {name}@{marketplace}. - Fix flaky
_git_env()tests by clearing leakedGIT_CONFIG_*environment variables before assertions. - Tighten a PluginsTab regression test to reject
copilot plugin install .and require marketplace-form output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/copilotsetup/tabs/plugins.py |
Replaces copilot plugin install . hints with name@marketplace form in detail pane and dev-install upgrade toast. |
tests/test_plugin_upgrades.py |
Removes leaked GIT_CONFIG_* env vars in _git_env() tests to eliminate flakiness. |
tests/test_plugins_tab.py |
Adds assertions to ensure dev-install upgrade messaging no longer suggests install . and uses marketplace form. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e form - Replace bare '.' argument (never valid) with name@marketplace format in detail pane and upgrade toast notification - Fix 3 flaky _git_env() tests by isolating GIT_CONFIG_COUNT from env - Tighten test assertion to reject bare dot and require @ form Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ericchansen
force-pushed
the
fix/plugin-install-hints
branch
from
10de8d6 to
8bd144e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace invalid
copilot plugin install .hint strings with the correctname@marketplaceform. Also fix 3 pre-existing flaky tests and add a regression guard.Changes
src/copilotsetup/tabs/plugins.py-- Replace bare.(never a valid plugin spec) with{name}@{marketplace}in:tests/test_plugin_upgrades.py-- Fix 3 flaky_git_env()tests that leakedGIT_CONFIG_COUNTfrom the runner environment (monkeypatch env vars clean)tests/test_plugins_tab.py-- Tighten assertion: reject bare.and require@marketplace formTesting
ruff checkandruff format --checkboth clean