Remove service account identity field from dataplane dialog#1946
Merged
GregorShear merged 3 commits intomainfrom Apr 3, 2026
Merged
Remove service account identity field from dataplane dialog#1946GregorShear merged 3 commits intomainfrom
GregorShear merged 3 commits intomainfrom
Conversation
GregorShear
changed the title
GregorShear
force-pushed
the
greg/dataplane-dialog
branch
from
cdb14f7 to
7f5a7fc
Compare
travjenkins
reviewed
Apr 3, 2026
travjenkins
reviewed
Apr 3, 2026
| })} | ||
| value={getRegionDisplayName( | ||
| dataPlaneName.provider as CloudProvider, | ||
| dataPlaneName.provider.toUpperCase() as CloudProvider, |
Member
There was a problem hiding this comment.
Do we just want to put this into the function this we know it always needs to be upper case?
Contributor
Author
There was a problem hiding this comment.
Yeah... did this and a little more cleanup of the casing convention
GregorShear
force-pushed
the
greg/dataplane-dialog
branch
from
2df34ef to
be8309d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1947
Raised with Dave et al in the Thursday office hours call, and James gave the thumbs up in Slack:
https://estuaryworkspace.slack.com/archives/C0AN2JHAGPJ/p1775139010652749
(also fixing the cloud provider and region fields that i probably broke with my big storage mapping PR a few weeks ago.)
