envvars: drop external python dependencies#288
Open
albestro wants to merge 1 commit intoeth-cscs:mainfrom
Open
envvars: drop external python dependencies#288albestro wants to merge 1 commit intoeth-cscs:mainfrom
albestro wants to merge 1 commit intoeth-cscs:mainfrom
Conversation
we relied on yaml dep installed by the system. since yaml is not part of the python stdlib but json is, here we rely on bash process substitution to pass a temporary file translated by yq from yaml to json.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envvars.pyis an internal utility used in the build phase of the uenv, where we use the system provided python installation.Since it is the system provided python installation, we don't have direct control of what dependencies are available, and we can either:
Given that at the moment we just rely on
yamlas external dep for a single call, I opted for the simplest and less intrusive solution which is the latter option, i.e. dropping this single external dependency.The first idea implemented is to create a temporary file through bash process substitution with
yq(tool which we already relied on in the past, probably worth forcing/checking its presence) where the yaml file is "translated" to json.Why should we care?
Because if we want to proceed with #273 the problem presented above should be fixed one way or the other.
TODO