fix: address PR37 review feedback — zero line counts and verification enum YAML#41
Merged
haasonsaas merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
… enum YAML - diff_parser: add regression assertions for @@ -0,0 +1,N @@ and @@ -N,N +0,0 @@ so zero line counts are preserved (Bugbot/CRITICAL). Add TDD test test_parse_new_file_multi_line_zero_old_lines. Main already uses parse_optional_capture without a zero filter; tests would fail if re-introduced. - config: add tests that deserialize verification_model_role and verification_consensus_mode from YAML (flat keys into config.verification). Assert weak/majority and primary/all; use config.verification.* after VerificationConfig flatten refactor. Made-with: Cursor
PR SummaryLow Risk Overview Adds YAML deserialization tests to verify flattened Written by Cursor Bugbot for commit c32c679. This will update automatically on new commits. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@@ -0,0 +1,N @@and@@ -N,N +0,0 @@). PR37/Bugbot had flagged that a.filter(|v| *v > 0)would break new/deleted file parsing; main already usesparse_optional_capturewithout that filter; these tests would fail if it were re-introduced.verification_model_roleandverification_consensus_modefrom YAML (flat keys intoconfig.verification). Covers weak/majority and primary/all; usesconfig.verification.model_role/consensus_modeafter the VerificationConfig flatten refactor on main.Test plan
cargo test diff_parser— 15 tests (includestest_parse_deleted_file,test_parse_new_file,test_parse_new_file_multi_line_zero_old_lines).cargo test test_config_deserialize_verification— 2 tests for YAML deserialize of verification enums.Made with Cursor