Skip to content

fix: address prior PR feedback — CI mutation grep, docs, eval DAG#42

Merged
haasonsaas merged 1 commit intomainfrom
fix/prior-pr-feedback
Mar 14, 2026
Merged

fix: address prior PR feedback — CI mutation grep, docs, eval DAG#42
haasonsaas merged 1 commit intomainfrom
fix/prior-pr-feedback

Conversation

@haasonsaas
Copy link
Collaborator

Summary

  • CI (PR40 feedback): Fix mutation job grep so it extracts the missed count (e.g. 2 from 14 mutants ... 2 missed, 9 caught), not the first number (14). The previous grep -oE '[0-9]+' | head -1 picked total mutants and caused spurious baseline failures.
  • README: Add PR workflow bullet under Contributing (CI green, test plan, small PRs).
  • docs/mutation-testing: State that *state* and *storage_pg* are not run in CI; add table from local run and re-run commands.
  • eval DAG (PR39 feedback): Add comment that ExpectationMatching / CommentCountValidation / BenchmarkMetrics form a linear chain so parallelizable: true has no effect today; keep for consistency.

Test plan

  • cargo test (no code behavior change beyond comment).
  • CI mutation job should now compare correct missed count to baseline.

Made with Cursor

…ment

- CI (PR40): Extract missed count from cargo-mutants summary correctly.
  Grep was taking first number (total mutants) instead of number before
  ' missed'; use sed to parse 'N missed' so baseline check is accurate.
- README: Add PR workflow note under Contributing.
- docs/mutation-testing: Note state/storage_pg not in CI; add local-run
  table and re-run commands.
- eval DAG (PR39): Comment that ExpectationMatching/CommentCount/Benchmark
  form a linear chain so parallelizable hint has no effect today; keep for
  consistency.

Made-with: Cursor
@cursor
Copy link

cursor bot commented Mar 14, 2026

PR Summary

Low Risk
Low risk: changes are limited to CI log parsing plus documentation/comment updates, with no runtime behavior changes in the shipped code.

Overview
Fixes the CI mutation-testing gate to extract the actual "missed" mutant count from cargo mutants output (avoiding false failures caused by capturing the total mutant count).

Updates contributor docs to clarify the PR workflow and to document that mutation testing for *state*/*storage_pg* is local-only (with a brief local-run summary and rerun commands). Adds a clarifying comment in the eval fixture DAG noting that several stages currently form a linear chain so parallelizable: true has no practical effect today.

Written by Cursor Bugbot for commit 39e5f9b. This will update automatically on new commits. Configure here.

@haasonsaas haasonsaas merged commit f4e9526 into main Mar 14, 2026
13 checks passed
@haasonsaas haasonsaas deleted the fix/prior-pr-feedback branch March 14, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant