Skip to content

test: more TDD coverage + version 0.5.27#46

Merged
haasonsaas merged 2 commits intomainfrom
feat/more-tests-tdd
Mar 14, 2026
Merged

test: more TDD coverage + version 0.5.27#46
haasonsaas merged 2 commits intomainfrom
feat/more-tests-tdd

Conversation

@haasonsaas
Copy link
Collaborator

Summary

  • Version bumped to 0.5.27.
  • Parsing: 3 new tests (single-quoted object in findings, escaped apostrophe, double-quoted apostrophe unchanged); convert_single_quoted_json_to_double fix for ' in single-quoted strings.
  • Guidance: 4 tests (no prose section when None/empty, single rule, special chars).
  • Triage: 2 tests (TriageOptions::default, reason exact).
  • Config: 2 tests (default and deserialize triage_skip_deletion_only false).

Test plan

  • cargo test (1371 tests)
  • cargo clippy --all-targets

Made with Cursor

Parsing (llm_response):
- parse_json_single_quoted_object_wrapped_in_findings
- parse_json_single_quoted_value_with_escaped_apostrophe
- parse_json_double_quoted_value_with_apostrophe_unchanged
- convert_single_quoted_json_to_double: fix \' in single-quoted string
  (emit apostrophe in JSON string, not backslash-doublequote)

Guidance:
- build_review_guidance_no_prose_section_when_rules_none/empty
- build_review_guidance_single_prose_rule
- build_review_guidance_prose_rule_with_special_chars

Triage:
- test_triage_options_default_skip_deletion_only_false
- test_reason_skip_deletion_only_exact

Config:
- test_config_default_triage_skip_deletion_only_false
- test_config_deserialize_triage_skip_deletion_only_false

Made-with: Cursor
@haasonsaas haasonsaas merged commit 5ed1887 into main Mar 14, 2026
@cursor
Copy link

cursor bot commented Mar 14, 2026

PR Summary

Low Risk
Low risk: changes are primarily new tests plus a small, well-covered tweak to JSON single-quote repair logic that could slightly alter parsing of malformed LLM responses.

Overview
Bumps crate version to 0.5.27 and extends test coverage across config, triage, and prompt-guidance generation to lock in expected defaults/edge cases.

Improves convert_single_quoted_json_to_double to correctly handle escaped apostrophes inside single-quoted JSON-like strings (e.g. don\'t), and adds parsing tests for single-quoted findings wrappers and apostrophe handling.

Written by Cursor Bugbot for commit 84b5454. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant