Skip to content

[WIP] test: use ev-reth pr-106 image to validate reth v1.10.1 upgrade #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chatton wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Draft

[WIP] test: use ev-reth pr-106 image to validate reth v1.10.1 upgrade #3066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions execution/evm/test/test_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func SetupTestRethNode(t *testing.T) *reth.Node {
dockerCli, dockerNetID := getTestScopedDockerSetup(t)

n, err := reth.NewNodeBuilderWithTestName(t, fmt.Sprintf("%s-%s", t.Name(), randomString(6))).
WithTag("pr-106").
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hardcoding the image tag pr-106 makes the test suite dependent on a temporary build artifact. Since this PR is a work-in-progress for testing, this is understandable, but this line should be removed before merging. For future flexibility, consider making the tag configurable via an environment variable, a pattern seen elsewhere in the test suite.

WithDockerClient(dockerCli).
WithDockerNetworkID(dockerNetID).
WithGenesis([]byte(reth.DefaultEvolveGenesisJSON())).
Expand Down
1 change: 1 addition & 0 deletions test/docker-e2e/docker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ type RethSetupConfig struct {
func (s *DockerTestSuite) SetupRethNode(ctx context.Context, name string) RethSetupConfig {
rethNode, err := reth.NewNodeBuilder(s.T()).
WithName(name).
WithTag("pr-106").
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This hardcoded tag pr-106 appears to be for temporary testing. Please consider making this configurable via an environment variable, similar to how getEvNodeImage handles image tags. This will improve maintainability and prevent pinning tests to a temporary build. This line should be removed before merging if the custom tag is not needed for the default test run.

WithGenesis([]byte(reth.DefaultEvolveGenesisJSON())).
WithDockerClient(s.dockerClient).
WithDockerNetworkID(s.dockerNetworkID).
Expand Down
Loading