Skip to content

Fix bank account ineffective concurrency test#2473

Merged
ErikSchierboom merged 4 commits intoexercism:mainfrom
tobias-haenel:main
Apr 1, 2026
Merged

Fix bank account ineffective concurrency test#2473
ErikSchierboom merged 4 commits intoexercism:mainfrom
tobias-haenel:main

Conversation

@tobias-haenel
Copy link
Copy Markdown
Contributor

See the bug report in the forum for more details

@github-actions
Copy link
Copy Markdown
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 30, 2026
@ErikSchierboom
Copy link
Copy Markdown
Member

@tobias-haenel You'll also need to re-run the generator for the exercise for the changes to appear.

@tobias-haenel
Copy link
Copy Markdown
Contributor Author

tobias-haenel commented Mar 31, 2026

@ErikSchierboom both running pwsh bin/update-excercises.ps1 or pwsh bin/update-tests under Linux didn't seem to update the BankAccountTests.cs file. Am I missing something?

It seems like Paths.ProbSpecsDir points to the non-existing directory path/to/my/cloned/repo/.problem-specifications do I need to set that up somehow to be symlinked to the problem-specifications repo?

@tobias-haenel
Copy link
Copy Markdown
Contributor Author

tobias-haenel commented Mar 31, 2026

Cloning the problem-specifications repo to .problem-specifications dir inside the csharp track repo dir made the generator work. Is that part on how template tests need to be regenerated documented somewhere? I couldn't find it in the contribution guidelines

@ErikSchierboom
Copy link
Copy Markdown
Member

There was an issue with the path to configlet. I've fixed it and pushed it to this branch.

@ErikSchierboom ErikSchierboom merged commit 67f2c19 into exercism:main Apr 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants