fix: handle BigInt status codes in res.status() and res.sendStatus()#7130
Open
JivinSardine wants to merge 1 commit intoexpressjs:masterfrom
Open
fix: handle BigInt status codes in res.status() and res.sendStatus()#7130JivinSardine wants to merge 1 commit intoexpressjs:masterfrom
JivinSardine wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Coerce BigInt to Number for compatibility with HTTP status codes. Fixes: TypeError when passing BigInt (e.g. 200n) to res.status() or res.sendStatus(), because JSON.stringify() cannot serialize BigInt values. Now BigInt status codes like 200n are automatically converted to 200 for proper HTTP status handling.
JivinSardine
force-pushed
the
fix/bigint-status-handling
branch
from
7cbf450 to
e7b4752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where passing a BigInt value (e.g.,
200n) tores.status()orres.sendStatus()would throw aTypeError: Do not know how to serialize a BigInt.Root Cause
The
res.status()function usesJSON.stringify(code)in its error message. When a BigInt is passed,JSON.stringify()throws because BigInt values cannot be serialized to JSON.Fix
Coerce BigInt values to Number before validation. HTTP status codes (100-999) are well within the safe range for JavaScript numbers.
Changes
res.status()sendStatusTest Results
All 1251 existing tests pass, plus 2 new BigInt-specific tests.
Fixes #6756