This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Replaced deprecated .getDOMNode() method with React.findDOMNode()#21
Open
mgibeau wants to merge 2 commits intoezequiel:masterfrom
Open
Replaced deprecated .getDOMNode() method with React.findDOMNode()#21mgibeau wants to merge 2 commits intoezequiel:masterfrom
mgibeau wants to merge 2 commits intoezequiel:masterfrom
Conversation
Conflicts: dist/react-typeahead-component.min.js
|
Looking forward for this merging. Anything I can do to help? |
|
Bump - any hold up on this? |
|
+1 @ezequiel, is there any reason this hasn't been merged? |
|
+1 |
4 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
@ezequiel Are there any updates on this getting merged? Is there anything we can do to help get this merged? |
|
Is there any reason this hasn't been merged? |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This suppresses the warnings thrown by react 0.14. I think to be fully compliant it should use ReactDOM.findDOMNode, but this is backward compatible with users still on 0.13.