Emit deprecated tag for deprecated LSP diagnostics#2887
Emit deprecated tag for deprecated LSP diagnostics#2887mvanhorn wants to merge 1 commit intofacebook:mainfrom
Conversation
When the error kind is Deprecated, emit DiagnosticTag::DEPRECATED on the LSP diagnostic. Editors that support this tag render a strikethrough over the deprecated name. Fixes facebook#2885
|
Hi @mvanhorn! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Emits DiagnosticTag::DEPRECATED on LSP diagnostics for deprecated error codes.
Why this matters
Editors that support LSP diagnostic tags render strikethrough on deprecated names. Pyrefly was missing this tag. Now deprecated functions get the visual cue.
Changes
tags: Noneto emitDiagnosticTag::DEPRECATEDwhenerror_kind() == ErrorKind::Deprecated.Testing
The change is a 6-line addition to a single file. ErrorKind derives PartialEq so the comparison is sound.
Fixes #2885
This contribution was developed with AI assistance (Claude Code).