Fix: trigger result_callback for single command apps (Issue #445)#1631
Open
dilanmelvin wants to merge 6 commits intofastapi:masterfrom
Open
Fix: trigger result_callback for single command apps (Issue #445)#1631dilanmelvin wants to merge 6 commits intofastapi:masterfrom
dilanmelvin wants to merge 6 commits intofastapi:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes Typer’s single-command “fast path” so result_callback is executed when an app has exactly one command and is invoked without specifying the command name (Issue #445).
Changes:
- Wrap the generated Click command callback for single-command apps to capture the command result.
- Invoke the app-level
result_callbackmanually after the command finishes, mirroring Click group behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Author
|
Maintainers, could you please add the bug label? |
Member
|
@dilanmelvin: you've asked for a review by copilot, so can you address its review comments? |
Author
|
@svlandeg The review is done as per the request from copilot ,Thankyou |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #445
This PR ensures that result_callback is triggered correctly even when the Typer application consists of a single command.
Problem
Currently, Typer optimizes single-command apps by executing them directly. In this specific execution path, the logic to invoke result_callback was missing, causing the callback to be silently ignored.
Solution
Modified get_command in typer/main.py to wrap the command callback. The wrapper executes the original command, captures the result, and then manually invokes the result_callback if one is defined.
Testing
I tested this locally with a script that returns a value from a single command:
Created a Typer app with one command returning a string.
Attached a result_callback to print the result.
Verified that the callback executes correctly after the command finishes.