Interpreter: fix strict refs/vars enforcement in eval STRING#227
Merged
Interpreter: fix strict refs/vars enforcement in eval STRING#227
Conversation
- Add LOAD_SYMBOLIC_SCALAR_NONSTRICT (338) and STORE_SYMBOLIC_SCALAR_NONSTRICT (339)
opcodes so BytecodeCompiler emits the strict variant when strict refs is active
and the non-strict variant otherwise, matching JVM compiler behaviour.
- Fix BytecodeCompiler.enterScope/exitScope to call emitterContext.symbolTable
.enterScope()/.exitScope() so pragma flags (strict/feature/warning) are
properly scoped to blocks — prevents use 5.012 inside {…} from leaking strict
into the surrounding code.
- Add strict vars check in compileVariableReference for the undeclared-global
path so Global-symbol errors are thrown at interpreter compile time.
Results:
comp/use.t interpreter: 40 → 44 passing
op/die.t interpreter: 19 → 25 passing (only pre-existing TODO test 26 remains)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interpreter: fix strict refs/vars enforcement in eval STRING
Add LOAD_SYMBOLIC_SCALAR_NONSTRICT (338) and STORE_SYMBOLIC_SCALAR_NONSTRICT (339)
opcodes so BytecodeCompiler emits the strict variant when strict refs is active
and the non-strict variant otherwise, matching JVM compiler behaviour.
Fix BytecodeCompiler.enterScope/exitScope to call emitterContext.symbolTable
.enterScope()/.exitScope() so pragma flags are properly scoped to blocks,
preventing use 5.012 inside a block from leaking strict into surrounding code.
Add strict vars check in compileVariableReference for the undeclared-global
path so Global-symbol errors are thrown at interpreter compile time.
Results:
comp/use.t interpreter: 40 -> 44 passing
op/die.t interpreter: 19 -> 25 passing (only pre-existing TODO test 26 remains)