Interpreter: fix comp/parser.t and op/postfixderef.t failures#230
Closed
Interpreter: fix comp/parser.t and op/postfixderef.t failures#230
Conversation
- BytecodeCompiler.handleCompoundAssignment: strip sigil before calling
NameNormalizer for both LOAD_GLOBAL_SCALAR and STORE_GLOBAL_SCALAR.
Previously "$main::n" was passed directly, causing a different global
key than the canonical "main::n" used by plain assignment.
- BytecodeCompiler.visit(BlockNode): sync ScopedSymbolTable scope with
block scope so getCurrentPackage() is correct at each eval() call site
inside the block (package Foo {} changes don't leak out).
- CompileOperator: bake call-site package into EVAL_STRING opcode as
pkgIdx, using ScopedSymbolTable.getCurrentPackage() at compile time.
- SlowOpcodeHandler: read pkgIdx from EVAL_STRING opcode and pass it to
EvalStringHandler as callSitePackage.
- EvalStringHandler: use callSitePackage instead of currentCode.compilePackage
so eval("__PACKAGE__") returns the correct package at each call site.
- InterpretedCode: update disassembler to consume pkgIdx in EVAL_STRING.
- CompileAssignment: use Perl-compatible error message for chop/chomp
non-lvalue assignment ("Can't modify chop in scalar assignment").
Fixes comp/package_block.t (4/5, matching JVM baseline),
op/chop.t (148/148).
….t 36,38,40)
When { q,bar, } is parsed as For3Node(isSimpleBlock=true), the body
executes but the block itself produces no value (lastResultReg = -1).
In a non-VOID context the enclosing BlockNode allocates outerResultReg
but never initialises it, leaving a null register slot that causes
ARRAY_SIZE and similar ops to NPE at runtime.
Fix: emit LOAD_UNDEF into a fresh register in the isSimpleBlock path
when currentCallContext != VOID, so callers always get a defined result.
The VOID path still sets lastResultReg = -1 as before (no allocation).
Fixes comp/parser.t tests 36, 38, 40 under JPERL_EVAL_USE_INTERPRETER=1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes interpreter-mode test failures under JPERL_EVAL_USE_INTERPRETER=1.\n\n## Changes\n\nBytecodeCompiler.java\n- visit(For3Node isSimpleBlock): emit LOAD_UNDEF in non-VOID context so outerResultReg is always initialised. Fixes NPE from eval "{ q,bar, }" where ARRAY_SIZE read a null register.\n- visit(For1Node): emit empty CREATE_LIST when node.list is null.\n\nCompileAssignment.java\n- Add postfix-deref glob lvalue: 'name'->** = value uses LOAD_GLOB_DYNAMIC + STORE_GLOB.\n\nBytecodeInterpreter.java\n- DEREF opcode: delegate to scalarDeref() for all RuntimeScalar; throws Not a SCALAR reference for GLOBREFERENCE.\n\nRuntimeScalar.java\n- scalarDerefNonStrict: throw Not a SCALAR reference for GLOBREFERENCE.\n\n## Test results (JPERL_EVAL_USE_INTERPRETER=1)\n- comp/parser.t: 61 passing (tests 36,38,40 fixed)\n- op/postfixderef.t: 85 passing (tests 27,28,29,59,63 fixed)\n- op/signatures.t: 598, op/chop.t: 137 (no regressions)