feat: add issuer specific fip validity to operator pages by MoritzWeber0 · Pull Request #684 · fipguide/fipguide.github.io

MoritzWeber0 · 2026-02-08T18:30:58Z

For each FIP issues a file called validity.yaml can be added to the corresponding operator directory, including information which how many coupons for which operator are issued. For example, let's have a look the at validity.yaml for FIP issuer DB:

_anchors:
  coupon-4fields: &coupon-4fields
    status: valid
    text:
      de: "1 Freifahrtschein mit jeweils 4 Feldern pro Jahr. Jedes Feld ist zwei Tage gültig."
      en: "1 coupon with 4 fields each per year. Each field is valid for two days."
      fr: "1 coupon avec 4 champs chacun par an. Chaque champ est valable deux jours."
  coupon-not-available: &coupon-not-available
    status: invalid
    text:
      de: "Nicht verfügbar"
      en: "Not available"
      fr: "Non disponible"
  reduced-50: &reduced-50
    status: valid
    text:
      de: "50 % Rabatt"
      en: "50 % discount"
      fr: "50 % de réduction"
pkp:
  fip-coupon: *coupon-4fields
  fip-coupon-relatives: *coupon-4fields
  fip-reduced-ticket: *reduced-50
zssk:
  fip-coupon: *coupon-4fields
  fip-coupon-relatives: *coupon-not-available
  fip-reduced-ticket: *reduced-50

Resolves #446

TODO:

netlify · 2026-02-08T18:31:49Z

✅ Deploy Preview for fipguide ready!

Name	Link
🔨 Latest commit	`b5bf5ea`
🔍 Latest deploy log	https://app.netlify.com/projects/fipguide/deploys/69b33e9e704d810008899fbf
😎 Deploy Preview	https://deploy-preview-684--fipguide.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

MoritzWeber0 · 2026-02-08T20:50:24Z

Should be ready for review now, @lenderom @therobrob. I'll keep it in the draft state until #680 is merged as this PR is based on it and should not be merged before.

lenderom · 2026-02-09T16:01:27Z

@MoritzWeber0 Thank you for your implementation. I think this will help many of our collegues. Do you think we should implement a kind of "Default" per employer? Like usually SNCF gives 1 Coupon with 4 Fields and we only specify the deviations on the operator site?

MoritzWeber0 · 2026-02-09T16:54:44Z

@MoritzWeber0 Thank you for your implementation. I think this will help many of our collegues. Do you think we should implement a kind of "Default" per employer? Like usually SNCF gives 1 Coupon with 4 Fields and we only specify the deviations on the operator site?

I'm against an implicitly added default. We should only add explicit information if we have it, otherwise let's fall back to unknown. The only reason would be less boilerplate (the YAML section grows a bit too quickly maybe). But there are probably better solutions like defining some defaults globally and then just reference them via a one-liner.

lenderom · 2026-02-09T17:44:10Z

@MoritzWeber0 Thank you for your implementation. I think this will help many of our collegues. Do you think we should implement a kind of "Default" per employer? Like usually SNCF gives 1 Coupon with 4 Fields and we only specify the deviations on the operator site?

I'm against an implicitly added default. We should only add explicit information if we have it, otherwise let's fall back to unknown. The only reason would be less boilerplate (the YAML section grows a bit too quickly maybe). But there are probably better solutions like defining some defaults globally and then just reference them via a one-liner.

Yeah I was more thinking about the boilerplate, not a "default" information but a way to avoid writing on every page "SBB employees have 8 fields every field is valid for one day" :D
But it's not a must have. Just an idea to avoid extremly large yaml metadata :)

lenderom · 2026-02-09T17:47:17Z

Another point I was thinking about was the considerationfo things like #681

It doesn't have to be implemented in this PR, I was just thinking about covering this problem in your implementation. For example instead of having a row in the table for the FIP Coupon there could be a text like "unlimited free travel". But we could also find other ways of covering this topic :)

MoritzWeber0 · 2026-02-09T17:57:03Z

Another point I was thinking about was the considerationfo things like #681

It doesn't have to be implemented in this PR, I was just thinking about covering this problem in your implementation. For example instead of having a row in the table for the FIP Coupon there could be a text like "unlimited free travel". But we could also find other ways of covering this topic :)

This is the reason why I removed some of the structured data from the previous PR and made it more flexible with the text :)
But for #681 I would need more information about who exactly gets those free benefits. So rather a separate PR.

therobrob

I’ve just reviewed the technical parts, not the md-files.

Two further comments:

for me it seems slightly confusing showing the grey status with question marks for cases, where we don’t know the information from all operators. It suggests we have no information at all. I think this case is very common, until we don’t have the information from all operators.
Edit: why do we handle the same case ("we don’t have information from all operators") in two different ways?
One time we say "valid" and one time we say "unknown" – where’s the difference between them?

this leads me to the second aspect: the button for the dialog isn’t optimal in my opinion. It is not self-explanatory, because there is no label and there is the second status-icon to the left (two icons, two different meanings for interacting). I envision a single, comprehensive button, so the user can click the whole information.

i18n/de.yaml

layouts/partials/fip-validity/main.html

layouts/partials/fip-validity-dialog.html

MoritzWeber0 · 2026-02-25T16:51:50Z

The table is now also available in the reverse format to find out for which operator how many coupons can be requested: https://deploy-preview-684--fipguide.netlify.app/de/fip-validity/

Copilot

Pull request overview

Adds issuer-specific FIP validity data (via per-issuer validity.yaml) and renders it on operator pages and on a new comparison page, so users can see coupon issuance and FIP50/75 reductions depending on their FIP card issuer.

Changes:

Introduce new Hugo shortcodes/partials to render FIP validity badges, dialogs, issuer dropdowns, and comparison tables.
Add issuer validity.yaml datasets for multiple issuers and update many operator pages to use the new fip-validity shortcode.
Add comparison page (/fip-validity) plus JS/CSS to drive issuer selection UI and responsive table/card layouts.

Reviewed changes

Copilot reviewed 115 out of 115 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
layouts/shortcodes/fip-validity.html	New shortcode wrapper for rendering a single validity badge + optional dialog.
layouts/shortcodes/fip-validity-comparison.html	New shortcode wrapper for rendering the comparison UI.
layouts/partials/fip-validity/main.html	Renders the clickable validity badge and (optionally) the dialog trigger/content.
layouts/partials/fip-validity/dialog.html	Builds issuer-specific dialog content by reading issuers’ `validity.yaml`.
layouts/partials/fip-validity/issuer-dropdown.html	Dropdown UI for selecting the FIP issuer (used on comparison page and dialogs).
layouts/partials/fip-validity/value.html	Renders a single status/value cell (icon + localized text).
layouts/partials/fip-validity/table.html	Renders the comparison table for an issuer/type across operators.
layouts/partials/fip-validity/comparison.html	Assembles the full comparison page UI for coupon + reduced ticket.
layouts/news/single.html	Adds wrapper class to enable horizontal overflow handling for wide content (tables).
layouts/_default/single.html	Adds wrapper class to enable horizontal overflow handling for wide content (tables).
i18n/de.yaml	Adds German translations for FIP validity UI texts and descriptions.
i18n/en.yaml	Adds English translations for FIP validity UI texts and descriptions.
i18n/fr.yaml	Adds French translations for FIP validity UI texts and descriptions.
content/fip-validity/index.de.md	New DE comparison landing page embedding the comparison shortcode.
content/fip-validity/index.en.md	New EN comparison landing page embedding the comparison shortcode.
content/fip-validity/index.fr.md	New FR comparison landing page embedding the comparison shortcode.
content/generalinformation/faq/what-rules-apply-to-fip-coupons/_index.de.md	Updates FAQ answer to point to the new comparison page.
content/generalinformation/faq/what-rules-apply-to-fip-coupons/_index.en.md	Updates FAQ answer to point to the new comparison page.
content/generalinformation/faq/what-rules-apply-to-fip-coupons/_index.fr.md	Updates FAQ answer to point to the new comparison page.
content/operator/db/validity.yaml	Adds DB-issued card validity matrix for multiple target operators.
content/operator/gb/validity.yaml	Adds GB-issued card validity matrix for multiple target operators.
content/operator/ns/validity.yaml	Adds NS-issued card validity matrix for multiple target operators.
content/operator/sncb/validity.yaml	Adds SNCB-issued card validity matrix for multiple target operators.
content/operator/sncf/validity.yaml	Adds SNCF-issued card validity matrix for multiple target operators.
content/operator/cd/validity.yaml	Adds ČD-issued card validity matrix for multiple target operators.
content/operator/bdz/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bdz/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bdz/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bls/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bls/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bls/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bsb/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bsb/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/bsb/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/cd/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/cd/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/cd/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/cfl/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/cfl/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/cfl/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes (and normalizes apostrophes).
content/operator/cp/index.de.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare).
content/operator/cp/index.en.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare).
content/operator/cp/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare).
content/operator/db/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/db/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/db/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/dsb/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/dsb/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/dsb/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/eurostar/index.de.md	Replaces inline validity list with `fip-validity` shortcodes (dialog disabled).
content/operator/eurostar/index.en.md	Replaces inline validity list with `fip-validity` shortcodes (dialog disabled).
content/operator/eurostar/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes (dialog disabled).
content/operator/euskotren/index.de.md	Replaces inline validity list with `fip-validity` shortcodes (uses `additional`).
content/operator/euskotren/index.en.md	Replaces inline validity list with `fip-validity` shortcodes (uses `additional`).
content/operator/euskotren/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes (uses `additional`).
content/operator/fs/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/fs/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/fs/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/gb/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/gb/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/gb/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/gysev/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/gysev/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/gysev/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/kd/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/kd/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/kd/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/ltg/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/ltg/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/ltg/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/ns/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/ns/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/ns/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/oebb/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/oebb/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/oebb/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/pkp/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/pkp/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/pkp/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/renfe/index.de.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare).
content/operator/renfe/index.en.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare).
content/operator/renfe/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare).
content/operator/sbb/index.de.md	Replaces inline validity list with `fip-validity` shortcodes; normalizes heading text.
content/operator/sbb/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/sbb/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/sncb/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/sncb/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/sncb/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/sncf/index.de.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare, dialog disabled).
content/operator/sncf/index.en.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare, dialog disabled).
content/operator/sncf/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes (incl. Global Fare, dialog disabled).
content/operator/sp/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/sp/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/sp/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/stl/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/stl/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/stl/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/zssk/index.de.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/zssk/index.en.md	Replaces inline validity list with `fip-validity` shortcodes.
content/operator/zssk/index.fr.md	Replaces inline validity list with `fip-validity` shortcodes.
assets/js/main.js	Registers the new comparison behavior script in the main bundle.
assets/js/fipValidityComparison.js	Adds issuer selection + persistence + syncing across dropdown instances.
assets/js/dropdown.js	Registers dropdown behavior for the new issuer dropdown instances; adds `closeDropdown` export.
assets/sass/main.scss	Includes the new `fip-validity.scss` stylesheet.
assets/sass/fip-validity.scss	New styling for validity badges, tables, cards, and issuer dropdown layout.
assets/sass/styles.scss	Enables horizontal scrolling for content wrapper (wide tables).
assets/sass/dropdown.scss	Adjusts dropdown menu border/margins (used by issuer dropdown).
assets/sass/dialog.scss	Adjusts dialog body height behavior (supports full-height dialogs).
assets/sass/button.scss	Improves disabled button interaction styling/behavior.
assets/sass/_variables.scss	Adds CSS variables for validity colors and a visible border token.
archetypes/operator/index.de.md	Updates operator archetype to use the new `fip-validity` shortcodes.
archetypes/operator/index.en.md	Updates operator archetype to use the new `fip-validity` shortcodes.
archetypes/operator/index.fr.md	Updates operator archetype to use the new `fip-validity` shortcodes.
AGENTS.md	Updates translation reference table wording/formatting.
.pre-commit-config.yaml	Adjusts YAML hook configuration for the new validity YAML files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

layouts/partials/fip-validity/main.html

layouts/partials/fip-validity/table.html

archetypes/operator/index.en.md

Copilot · 2026-03-12T22:37:33Z

archetypes/operator/index.de.md

+
+{{< fip-validity type="fip-coupon" status="valid" >}}
+{{< fip-validity type="fip-reduced-ticket" status="valid" >}}
+{{< fip-validity type="fip-global-fare" status="valid" >}}


Same issue as in the EN archetype: the Global Fare shortcode will open a dialog that looks up fipValidity.fip-global-fare-description, but that translation key is missing. Add the missing translation keys or disable the dialog for this type in the archetype.

Suggested change

{{< fip-validity type="fip-global-fare" status="valid" >}}

{{< fip-validity type="fip-global-fare" status="valid" disable_dialog="true" >}}

archetypes/operator/index.fr.md

layouts/partials/fip-validity/issuer-dropdown.html

layouts/shortcodes/fip-validity.html

layouts/partials/fip-validity/value.html

layouts/partials/fip-validity/table.html

i18n/de.yaml

MoritzWeber0 mentioned this pull request Feb 8, 2026

feat: Render FIP validity from params #477

Closed

MoritzWeber0 requested review from lenderom and therobrob February 8, 2026 20:50

therobrob reviewed Feb 9, 2026

View reviewed changes

i18n/de.yaml Outdated Show resolved Hide resolved

layouts/partials/fip-validity/main.html Show resolved Hide resolved

layouts/partials/fip-validity-dialog.html Outdated Show resolved Hide resolved

layouts/partials/fip-validity-dialog.html Outdated Show resolved Hide resolved

MoritzWeber0 force-pushed the feat/add-dialogs branch from 63d2c58 to 8a78d2e Compare February 10, 2026 07:57

MoritzWeber0 added 9 commits February 10, 2026 08:58

feat: Add support for dialogs

8639720

fix: show dialog triggers as inline text

4dfaab2

feat: Also open dialog on enter key

ef23d16

fix: z-index

146546c

refactor: improve naming of classes

c0046e3

fix: rounded scrollbar corners

79e1d3c

refactor: rename button classes

0014b52

feat: use dvh instead vh

c9f9a0c

fix: Remove stena line dialog

ea75e56

MoritzWeber0 force-pushed the feat/add-dialogs branch 2 times, most recently from 1b5a622 to ea75e56 Compare February 10, 2026 08:02

MoritzWeber0 added 7 commits February 10, 2026 09:13

feat: Improve accessibility on dialog-trigger

6e968d3

fix: Improve accessibility on dialog close button

7fcbbc1

feat: Make dialog header sticky

930dc73

feat: Make icon margin in links more generic

46069eb

fix: Descrease margin top/bottom for dialog header

aea2d39

fix: Increase headings in dialog

9234929

fix: Move dialog close button to the right

c04e69e

MoritzWeber0 force-pushed the feat/fip-validity branch from 369eb6a to af72ab6 Compare February 24, 2026 18:59

feat: Add FIP validity comparison

7a282ea

Base automatically changed from feat/add-dialogs to main February 24, 2026 21:35

MoritzWeber0 added 4 commits February 25, 2026 09:08

feat: Move fip-validity partials into folder

664dc13

fix: Update validity information

8b2c2d3

fix: Text overflow

ae59a23

Merge remote-tracking branch 'origin/main' into feat/fip-validity

741a103

MoritzWeber0 marked this pull request as ready for review February 25, 2026 16:51

MoritzWeber0 requested a review from therobrob February 25, 2026 16:52

MoritzWeber0 added 15 commits February 25, 2026 17:59

feat: Align France region nord

b0fee52

feat: Add text styling for fip validity

2137526

feat: Store selected FIP issuer in local storage

20a733f

feat: Add dropdown menu for operator fip validity

264ac90

Merge remote-tracking branch 'origin/main' into feat/fip-validity

22248c4

fix: Hide eurostar and euskotren from FIP validity

5779655

fix: Excluded operators in fip validity list

9e55309

refactor: Use issuer-dropdown in comparison

0cc82f3

fix: Grammatical issues

7d2ee5f

fix: Replace table with cards

d5c3d08

feat: Add operator logo as placeholder

2f16dad

feat: Make border always visible

d6ad85d

Merge branch 'main' into feat/fip-validity

b1245af

refactor: Merge comparison into fip-validity

72cb743

refactor: Rename table-cell to value

120536e

MoritzWeber0 mentioned this pull request Mar 7, 2026

refactor: Unify dropdown implementations #738

Draft

Merge branch 'main' into feat/fip-validity

b5bf5ea

MoritzWeber0 requested a review from Copilot March 12, 2026 22:31

Copilot started reviewing on behalf of MoritzWeber0 March 12, 2026 22:31 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

	{{< fip-validity type="fip-global-fare" status="valid" >}}
	{{< fip-validity type="fip-global-fare" status="valid" disable_dialog="true" >}}

Uh oh!

Conversation

MoritzWeber0 commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fipguide ready!

Uh oh!

MoritzWeber0 commented Feb 8, 2026

Uh oh!

lenderom commented Feb 9, 2026

Uh oh!

MoritzWeber0 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lenderom commented Feb 9, 2026

Uh oh!

lenderom commented Feb 9, 2026

Uh oh!

MoritzWeber0 commented Feb 9, 2026

Uh oh!

therobrob left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MoritzWeber0 commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MoritzWeber0 commented Feb 8, 2026 •

edited

Loading

netlify bot commented Feb 8, 2026 •

edited

Loading

MoritzWeber0 commented Feb 9, 2026 •

edited

Loading

therobrob left a comment •

edited

Loading