Use custom splitter component#4606
Draft
mstange wants to merge 2 commits intofirefox-devtools:mainfrom
Draft
Conversation
3dd644e to
432dc91
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4606 +/- ##
==========================================
- Coverage 85.45% 85.38% -0.07%
==========================================
Files 321 322 +1
Lines 32139 32152 +13
Branches 8850 8848 -2
==========================================
- Hits 27463 27452 -11
- Misses 4241 4265 +24
Partials 435 435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
This replaces the splitter component with an implementation which lets us use
max-heighton the timeline, so that we don't have to compute the timeline height based on the visible tracks.This PR also removes panelLayoutGeneration because it's no longer needed; it originally resolved #1205 and #736 but these days we have ResizeObservers in the relevant places.
┆Issue is synchronized with this Jira Task