Skip to content

Use custom splitter component#4606

Draft
mstange wants to merge 2 commits intofirefox-devtools:mainfrom
mstange:new-splitter
Draft

Use custom splitter component#4606
mstange wants to merge 2 commits intofirefox-devtools:mainfrom
mstange:new-splitter

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented May 4, 2023

Production | Deploy preview

This replaces the splitter component with an implementation which lets us use max-height on the timeline, so that we don't have to compute the timeline height based on the visible tracks.

This PR also removes panelLayoutGeneration because it's no longer needed; it originally resolved #1205 and #736 but these days we have ResizeObservers in the relevant places.

┆Issue is synchronized with this Jira Task

@canova canova mentioned this pull request Sep 4, 2025
4 tasks
@mstange mstange marked this pull request as ready for review April 2, 2026 22:13
@mstange mstange requested review from canova and fatadel as code owners April 2, 2026 22:13
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 46.93878% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.38%. Comparing base (c886717) to head (d644702).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/shared/ResizableWithSplitter.tsx 36.73% 31 Missing ⚠️
src/components/shared/Draggable.tsx 30.43% 16 Missing ⚠️
src/components/app/BottomBox.tsx 72.22% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
- Coverage   85.45%   85.38%   -0.07%     
==========================================
  Files         321      322       +1     
  Lines       32139    32152      +13     
  Branches     8850     8848       -2     
==========================================
- Hits        27463    27452      -11     
- Misses       4241     4265      +24     
  Partials      435      435              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange marked this pull request as draft April 4, 2026 00:03
@canova canova removed request for canova and fatadel April 7, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hiding/showing timeline tracks doesn't invalidate all the sizing state in components

1 participant