fix(smart-nav-menu): use parent extension id for shortcut permission check#122
Merged
fix(smart-nav-menu): use parent extension id for shortcut permission check#122
Conversation
…check Shortcuts registered via registerHeaderMenuItem() are stored as first-class items in the universe registry with _isShortcut: true and _parentId pointing to the parent extension. The allItems getter was running the ability check against the shortcut's own id (e.g. 'ledger-sc-transactions see extension'), which has no registered ability and therefore always fell through to the catch block, making every shortcut unconditionally visible regardless of whether the user can see the parent extension. Fix: when an item is a shortcut (_isShortcut && _parentId), use _parentId as the ability subject instead of item.id. This means a shortcut is visible if and only if its parent extension is visible, which is the correct behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Shortcuts registered via
registerHeaderMenuItem()are stored as first-class items in the universe registry with_isShortcut: trueand_parentIdpointing to the parent extension.The
allItemsgetter insmart-nav-menu.jswas running the ability check against the shortcut's ownid(e.g.ledger-sc-transactions see extension), which has no registered ability. This caused every shortcut to always fall through to thecatchblock and be unconditionally included — regardless of whether the user actually has permission to see the parent extension.Fix
When an item is a shortcut (
_isShortcut && _parentId), use_parentIdas the ability subject instead ofitem.id:This means a shortcut is visible if and only if its parent extension is visible, which is the correct behaviour. If the parent extension has no registered ability (catch block), the shortcut is also included by default — consistent with how parent extensions are handled.