Skip to content

helpers: Decide LMP_VERSION by branch instead of HEAD#408

Open
angolini wants to merge 1 commit intofoundriesio:masterfrom
angolini:LMP_VERSION_by_branch
Open

helpers: Decide LMP_VERSION by branch instead of HEAD#408
angolini wants to merge 1 commit intofoundriesio:masterfrom
angolini:LMP_VERSION_by_branch

Conversation

@angolini
Copy link
Copy Markdown
Contributor

Instead of always searching for the latest tag from main, first detect which branch was initialized by repo and then fetch the latest tag.

Tested by

repo init --no-clone-bundle -u https://github.com/foundriesio/lmp-manifest -b main
export H_PROJECT=lmp
source /home/daiane/foundries/ci-scripts/helpers.sh 
set_base_lmp_version


repo init --no-clone-bundle -u https://github.com/foundriesio/lmp-manifest -b scarthgap
export H_PROJECT=lmp
source /home/daiane/foundries/ci-scripts/helpers.sh 
set_base_lmp_version

I'm not exactly sure how to get the first repo init command line, so I guessed. If there is a better way to test it, please advice.

It returns 96 for main and 97 for scarthgap, as the main logic of using the next version is maintained

Instead of always searching for the latest tag from main, first detect
which branch was initialized by repo and then fetch the latest tag.

Signed-off-by: Daiane Angolini <daiane.angolini@foundries.io>
@ricardosalveti
Copy link
Copy Markdown
Member

But then main will use the v96 + 1 bucket, is this what we want?

@ricardosalveti
Copy link
Copy Markdown
Member

If we don't expect releasing main anymore I would just move main to use a different sstate cache bucket and drop most of this logic.

@angolini
Copy link
Copy Markdown
Contributor Author

@ricardosalveti I'm still unsure how to proceed, in an attempt of better understanding this I made this silly change.

Not exactly thinking about tags on main, but tags on each LTS branch, how to keep it up with CVE stable updates being released in the future.

I agree that the sstate_cache remote directories management has to align with this logic. But today this management is unclear to me, so I hear any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants