helpers: Decide LMP_VERSION by branch instead of HEAD#408
Open
angolini wants to merge 1 commit intofoundriesio:masterfrom
Open
helpers: Decide LMP_VERSION by branch instead of HEAD#408angolini wants to merge 1 commit intofoundriesio:masterfrom
angolini wants to merge 1 commit intofoundriesio:masterfrom
Conversation
Instead of always searching for the latest tag from main, first detect which branch was initialized by repo and then fetch the latest tag. Signed-off-by: Daiane Angolini <daiane.angolini@foundries.io>
Member
|
But then main will use the v96 + 1 bucket, is this what we want? |
Member
|
If we don't expect releasing main anymore I would just move main to use a different sstate cache bucket and drop most of this logic. |
Contributor
Author
|
@ricardosalveti I'm still unsure how to proceed, in an attempt of better understanding this I made this silly change. Not exactly thinking about tags on main, but tags on each LTS branch, how to keep it up with CVE stable updates being released in the future. I agree that the sstate_cache remote directories management has to align with this logic. But today this management is unclear to me, so I hear any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always searching for the latest tag from main, first detect which branch was initialized by repo and then fetch the latest tag.
Tested by
I'm not exactly sure how to get the first
repo initcommand line, so I guessed. If there is a better way to test it, please advice.It returns 96 for main and 97 for scarthgap, as the main logic of using the next version is maintained