Change Recognize Spell (PF) and Face in the Crowd (SF) localization keys#21784
Closed
Cuingamehtar wants to merge 1 commit intofoundryvtt:v13-devfrom
Closed
Change Recognize Spell (PF) and Face in the Crowd (SF) localization keys#21784Cuingamehtar wants to merge 1 commit intofoundryvtt:v13-devfrom
Cuingamehtar wants to merge 1 commit intofoundryvtt:v13-devfrom
Conversation
Collaborator
|
Can we hold off on the sort until after the books drop on April 1st? The localization work has already started on that pre-release branch, and this would be a pretty hard one to avoid conflicts with |
Cuingamehtar
changed the title
Contributor
Author
|
Sure, no problem. I've kept only the key changes. |
Collaborator
|
Conflicts |
Contributor
Author
|
Actually, at this point I'll drop it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keys were changed because they were the only entries in their subcategory.
Primary reason to sort keys that was so that I could just add RE localizations without bothering with order and have them sorted automatically later.
Unfortunately, this is not the complete sort, as there are cases where I felt preserving sequential order is more valuable than having keys in alphabetical.