Revamp how testing is done#96
Merged
pedritomelenas merged 1 commit intomasterfrom May 6, 2026
Merged
Conversation
c4128fa to
9997342
Compare
Now there are four tst/test*.g files, testing with different helper packages available.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 86.27% 87.80% +1.52%
==========================================
Files 60 57 -3
Lines 12825 12464 -361
==========================================
- Hits 11065 10944 -121
+ Misses 1760 1520 -240 🚀 New features to boost your workflow:
|
fingolfin
commented
May 6, 2026
Comment on lines
+65
to
+69
| #- name: "Test with 4ti2interface loaded" # FIXME: disabled due to errors in the tests | ||
| # uses: gap-actions/run-pkg-tests@v4 | ||
| # with: | ||
| # testfile: "tst/test-with-4ti2.g" | ||
|
|
Member
Author
There was a problem hiding this comment.
Pedro some errors occur, see this log. For example:
########> Diff in /tmp/gaproot/pkg/numericalsgps/tst/testall.tst:291
# Input is:
MinimalGenerators(a);
# Expected output:
[ [ 1, 1 ], [ 1, 2 ], [ 2, 1 ], [ 3, 1 ] ]
# But found:
[ [ 3, 1 ], [ 1, 2 ], [ 1, 1 ], [ 2, 1 ] ]
########
which seems harmless (the order changed; perhaps the output of MinimalGenerators should be sorted?
The second error looks more serious:
########> Diff in /tmp/gaproot/pkg/numericalsgps/tst/testall.tst:1875
# Input is:
IsGradedAssociatedRingNumericalSemigroupGorenstein(s);
# Expected output:
false
# But found:
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `+' on 2 arguments
The 2nd argument is 'fail' which might point to an earlier problem
########
Contributor
There was a problem hiding this comment.
I see were the problem is. We muted factorizations in 4ti2 and large factorizations are required for omega computations. Also, the output of generators is not transformed to set. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now there are four tst/test*.g files, testing with different helper packages available.