Skip to content

Revamp how testing is done#96

Merged
pedritomelenas merged 1 commit intomasterfrom
mh/revamp-tests
May 6, 2026
Merged

Revamp how testing is done#96
pedritomelenas merged 1 commit intomasterfrom
mh/revamp-tests

Conversation

@fingolfin
Copy link
Copy Markdown
Member

Now there are four tst/test*.g files, testing with different helper packages available.

@fingolfin fingolfin force-pushed the mh/revamp-tests branch 2 times, most recently from c4128fa to 9997342 Compare May 6, 2026 11:59
Now there are four tst/test*.g files, testing with different
helper packages available.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.80%. Comparing base (fe65bd9) to head (b5ad64e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   86.27%   87.80%   +1.52%     
==========================================
  Files          60       57       -3     
  Lines       12825    12464     -361     
==========================================
- Hits        11065    10944     -121     
+ Misses       1760     1520     -240     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin requested a review from pedritomelenas May 6, 2026 12:41
Comment thread .github/workflows/CI.yml
Comment on lines +65 to +69
#- name: "Test with 4ti2interface loaded" # FIXME: disabled due to errors in the tests
# uses: gap-actions/run-pkg-tests@v4
# with:
# testfile: "tst/test-with-4ti2.g"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedro some errors occur, see this log. For example:

########> Diff in /tmp/gaproot/pkg/numericalsgps/tst/testall.tst:291
# Input is:
MinimalGenerators(a);
# Expected output:
[ [ 1, 1 ], [ 1, 2 ], [ 2, 1 ], [ 3, 1 ] ]
# But found:
[ [ 3, 1 ], [ 1, 2 ], [ 1, 1 ], [ 2, 1 ] ]
########

which seems harmless (the order changed; perhaps the output of MinimalGenerators should be sorted?

The second error looks more serious:

########> Diff in /tmp/gaproot/pkg/numericalsgps/tst/testall.tst:1875
# Input is:
IsGradedAssociatedRingNumericalSemigroupGorenstein(s);
# Expected output:
false
# But found:
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `+' on 2 arguments
The 2nd argument is 'fail' which might point to an earlier problem

########

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see were the problem is. We muted factorizations in 4ti2 and large factorizations are required for omega computations. Also, the output of generators is not transformed to set. Thanks

@pedritomelenas pedritomelenas merged commit d1fe793 into master May 6, 2026
7 checks passed
@pedritomelenas pedritomelenas deleted the mh/revamp-tests branch May 6, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants