fix: clean up prefix-mode gstack-* directories on uninstall#902
Open
mvanhorn wants to merge 2 commits intogarrytan:mainfrom
Open
fix: clean up prefix-mode gstack-* directories on uninstall#902mvanhorn wants to merge 2 commits intogarrytan:mainfrom
mvanhorn wants to merge 2 commits intogarrytan:mainfrom
Conversation
The Claude cleanup section only removed symlinks pointing into gstack/, missing real gstack-* directories created by prefix-mode installs. This adds glob-based cleanup matching the pattern already used for Codex, Factory, and Kiro hosts. Also handles project-local prefix-mode dirs and shows prefix directory count in the confirmation prompt. Fixes garrytan#896
Verifies that real gstack-* directories (not symlinks) in ~/.claude/skills/ are removed by gstack-uninstall, while non-gstack directories are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gstack-uninstall skips real gstack-* directories in ~/.claude/skills/ because the Claude cleanup section only iterates symlinks (
[ -L ] || continue). Prefix-mode installs create real directories (gstack-browse/, gstack-qa/, etc.), not symlinks, so they survive uninstall.Changes
Added glob-based cleanup for
gstack-*entries in three places:~/.claude/skills/gstack-*directories (matches existing Codex/Factory/Kiro pattern).claude/skills/gstack-*directoriesTesting
New test: creates real gstack-browse/ and gstack-qa/ directories, runs
--forceuninstall, verifies both are removed while non-gstack directories survive.All existing tests pass (7/7 new, 1 pre-existing failure on
clean systemtest unrelated to this change - the SessionStart hook fires even on clean systems).Fixes #896
This contribution was developed with AI assistance (Claude Code).