fix(vscode): keep legacy Copilot hooks active in WSL/SSH/remote contexts#1189
Open
jorgegarciarey wants to merge 1 commit into
Open
fix(vscode): keep legacy Copilot hooks active in WSL/SSH/remote contexts#1189jorgegarciarey wants to merge 1 commit into
jorgegarciarey wants to merge 1 commit into
Conversation
In remote contexts (WSL, SSH, Codespaces, dev containers), native Copilot hooks fire on the Local Extension Host where Copilot runs, but git-ai runs on the Remote Extension Host. VS Code's Remote protocol does not relay these hooks across hosts, so we must keep legacy hooks active. - Add optional `remoteName` param to `shouldSkipLegacyCopilotHooks()` - Pass `vscode.env.remoteName` from AIEditManager constructor - Add tests for WSL, SSH, dev-container, and codespaces contexts Fixes git-ai-project#1187
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Member
|
Thank you for your first contribution @jorgegarciarey -- excited for more!! Quick question, how has this update been working for you on remove envs/devcontainers? I need to dig deeper, but two things come to mind: a) Shocked that the copilot hooks would run locally (🤯). Is this documented or are they looking at fixing this? Any way we could configure our hooks to run on the remote? Ideally, we could figure out a fix that doesn't require using the legacy/extension model, but open to it if that's our only option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1188