remove clipboard.js use vanilla javascript#1318
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the clipboard.js external library dependency and replaces it with a vanilla JavaScript implementation, addressing issue #1138. The change reduces dependencies and uses modern browser APIs for clipboard functionality.
Key Changes:
- Implemented native clipboard functionality using
navigator.clipboard.writeText()with fallback todocument.execCommand('copy') - Replaced clipboard.js event-based architecture with direct event listeners for click, mouseleave, and blur events
- Removed all clipboard.js vendor files and updated build configuration accordingly
Reviewed changes
Copilot reviewed 4 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/js/app.js | Replaced clipboard.js with vanilla JavaScript implementation using modern Clipboard API and execCommand fallback |
| _includes/footer.html | Removed clipboard.min.js script tag |
| bower.json | Removed clipboard dependency from bower configuration |
| _config.yml | Removed clipboard test directory from exclusions |
| .gitignore | Removed clipboard vendor directory exclusions |
| assets/vendor/clipboard/* | Deleted all clipboard.js vendor files (dist, documentation, configuration) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1138