Conversation
Require testcase access before serving task logs and escape Cloud Logging filter values so task parameters cannot bypass the intended query constraints.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
Install pipenv into the activated virtualenv before bootstrap runs so the later python3.11 -m pipenv requirements export does not fail when pipenv is only available globally.
|
Updated this branch with the latest master and addressed the two concrete CI failures seen on the previous head:
I also verified locally that the task-log filter export commands now succeed, and I checked The new GitHub Actions runs for head |
|
/gcbrun |
Keep the task-log changes lint-clean, use pipenv's CLI directly for bootstrap requirement exports so the active interpreter can resolve it more reliably, and switch the Kubernetes e2e setup to sync from the lock file instead of relocking in CI.
This change protects /testcase-detail/task-log by enforcing testcase access checks before returning log content.
It also escapes task log filter values before building the Cloud Logging query so user-controlled task parameters cannot alter the intended filter.