Skip to content

Swarming: Calculates CF zip url in preprocess to be used in main#5235

Merged
javanlacerda merged 15 commits intomasterfrom
feature/swarming/send_metadata_server_values
Apr 10, 2026
Merged

Swarming: Calculates CF zip url in preprocess to be used in main#5235
javanlacerda merged 15 commits intomasterfrom
feature/swarming/send_metadata_server_values

Conversation

@IvanBM18
Copy link
Copy Markdown
Collaborator

@IvanBM18 IvanBM18 commented Apr 6, 2026

The setups scripts rely on a set of values that form the GS storage url to download the latest CF .zip, these values either come from the env vars, or the metadata server.

Since in swarming we don't have metadata server, we are calculating these values beforehand and sending them as env vars in the swarming request.

Test Proofs

These changes have been in dev since last week. We have successfully use them to fix this issue:

Downloading ClusterFuzz source code.
++ '[' '' = 1 ']'
++ gsutil cp gs:///linux-3.zip clusterfuzz_package.zip

Allowing the code to tgarget the correct URL:

Downloading ClusterFuzz source code.
++ '[' '' = 1 ']'
++ gsutil cp gs://deployment.clusterfuzz-development.appspot.com/linux-3.zip clusterfuzz_package.zip

Note: The failing e2e check is known to be failing right now so we can ignore that

@IvanBM18 IvanBM18 requested a review from jardondiego April 6, 2026 23:26
@IvanBM18 IvanBM18 self-assigned this Apr 6, 2026
@IvanBM18 IvanBM18 added the swarming Changes related to the clusterfuzz-swarming integration label Apr 6, 2026
@IvanBM18 IvanBM18 changed the title Swarming: Calculates CF zip url in tworker beforehand Swarming: Calculates CF zip url in preprocess to be used in main Apr 6, 2026
@IvanBM18 IvanBM18 force-pushed the feature/swarming/send_metadata_server_values branch from 7d8ed08 to 7ad0b2e Compare April 8, 2026 17:07
@IvanBM18 IvanBM18 requested review from javanlacerda and letitz April 8, 2026 21:00
@IvanBM18 IvanBM18 marked this pull request as ready for review April 8, 2026 21:00
@IvanBM18 IvanBM18 requested a review from a team as a code owner April 8, 2026 21:00
Copy link
Copy Markdown
Collaborator

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a couple comments below, to avoid blocking on me further.

Copy link
Copy Markdown
Collaborator

@jardondiego jardondiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javanlacerda javanlacerda merged commit c730807 into master Apr 10, 2026
9 of 10 checks passed
@javanlacerda javanlacerda deleted the feature/swarming/send_metadata_server_values branch April 10, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

swarming Changes related to the clusterfuzz-swarming integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants