Swarming: Calculates CF zip url in preprocess to be used in main#5235
Merged
javanlacerda merged 15 commits intomasterfrom Apr 10, 2026
Merged
Swarming: Calculates CF zip url in preprocess to be used in main#5235javanlacerda merged 15 commits intomasterfrom
javanlacerda merged 15 commits intomasterfrom
Conversation
7d8ed08 to
7ad0b2e
Compare
letitz
approved these changes
Apr 9, 2026
Collaborator
letitz
left a comment
There was a problem hiding this comment.
LGTM modulo a couple comments below, to avoid blocking on me further.
javanlacerda
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setups scripts rely on a set of values that form the
GS storage urlto download the latest CF .zip, these values either come from the env vars, or the metadata server.Since in swarming we don't have metadata server, we are calculating these values beforehand and sending them as env vars in the swarming request.
Test Proofs
These changes have been in
devsince last week. We have successfully use them to fix this issue:Allowing the code to tgarget the correct URL:
Note: The failing e2e check is known to be failing right now so we can ignore that