impl(oauth2): add methods for returning multiple auth related http headers#16064
impl(oauth2): add methods for returning multiple auth related http headers#16064scotthart merged 2 commits intogoogleapis:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the credential authentication system to support multiple HTTP headers, replacing the single AuthenticationHeader with a vector-based AuthenticationHeaders method and adding specific logic for Authorization and AllowedLocations. A review comment suggests that errors from AllowedLocations should be handled more explicitly—either by logging or propagation—to avoid sending requests with missing headers that might cause ambiguous service failures.
186e65c to
ee8c220
Compare
ee8c220 to
e64f424
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16064 +/- ##
==========================================
- Coverage 92.70% 92.69% -0.01%
==========================================
Files 2343 2343
Lines 216644 216674 +30
==========================================
+ Hits 200838 200850 +12
- Misses 15806 15824 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds methods for retrieving the
authorizationandx-allowed-locationsheaders individually, as well as, theAuthenticationHeadersmethod as a single place to get all the auth related headers for RPC calls.Similar changes for the gRPC auth path is being handled in the gRPC library.