Skip to content

chore(migration): Migrate code from googleapis/python-spanner-django into packages/django-google-spanner#16045

Merged
chalmerlowe merged 582 commits intomainfrom
migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate
Mar 13, 2026
Merged

chore(migration): Migrate code from googleapis/python-spanner-django into packages/django-google-spanner#16045
chalmerlowe merged 582 commits intomainfrom
migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 6, 2026

See #10953.

This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.

timgraham and others added 30 commits April 17, 2020 15:03
Also while here, fixed a typo in a setting field for `DATABASES`
that used
    DATABASE
instead of
    NAME

for the name of the database.

Fixes #433
)

The proper name is data_type_check_constraints (no 's' after type) but
Spanner doesn't have check constraints anyway.

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
This reverts commit 7959874a6f09da750533d10f90d94320e082be76.

fixes #444
fixes #227

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
* chore: add renovate.json

Co-authored-by: skuruppu <skuruppu@google.com>
* feat: add PyPI release support

* fix: update package name

Fixes #455 

* deps: remove dependency on google-cloud

* chore: added extra fields to setup.py

* fix: single-source the version

* fix: made setup.py consistent with client lib

* fix: removed comment that no longer applies

* fix: only support python version >=3.5

* add missing os import

* add missing io import

* fix README file extension

* add missing pkg_resources import

* fix import ordering

Co-authored-by: larkee <larkee@users.noreply.github.com>
@ohmayr ohmayr self-assigned this Mar 9, 2026
@ohmayr ohmayr force-pushed the migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate branch 2 times, most recently from c80102c to 241ad70 Compare March 9, 2026 14:01
@ohmayr ohmayr force-pushed the migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate branch from 241ad70 to 4b0b3b4 Compare March 9, 2026 16:28
@ohmayr ohmayr force-pushed the migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate branch from 609e531 to 5edc4e5 Compare March 10, 2026 19:37
@ohmayr ohmayr force-pushed the migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate branch from 34d8c78 to 9694001 Compare March 11, 2026 17:45
@ohmayr ohmayr force-pushed the migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate branch from 9694001 to 379c65a Compare March 12, 2026 22:48
@ohmayr ohmayr marked this pull request as ready for review March 13, 2026 19:11
@ohmayr ohmayr requested review from a team as code owners March 13, 2026 19:11
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the best of my knowledge, this looks reasonable.
I have made several comments that should be addressed.

There are several tests not yet passing.
It looks like the three failing tests were not passing in the old repo, either.

Approving this pending the completion of the comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the owl-bot-staging directory and contents.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to delete this and the 3.7 file. Leaving the lowest constraint file as 3.8. Move this content with any minor tweaks, as needed to the 3.8 file.

@chalmerlowe chalmerlowe merged commit 90b444e into main Mar 13, 2026
53 of 57 checks passed
@chalmerlowe chalmerlowe deleted the migration.python-spanner-django.migration.2026-03-06_19-24-38.migrate branch March 13, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.